From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: Re: [PATCH 2/2] media: vim2m: ensure that width is multiple of two
Date: Tue, 26 Feb 2019 15:04:13 -0300 [thread overview]
Message-ID: <20190226150413.44afefb2@coco.lan> (raw)
In-Reply-To: <0a47c5ad8099c5988e961d44221b4a95d74f8322.1551202610.git.mchehab+samsung@kernel.org>
Em Tue, 26 Feb 2019 14:36:55 -0300
Mauro Carvalho Chehab <mchehab+samsung@kernel.org> escreveu:
> The copy logic assumes that the data width is multiple of two,
> as this is needed in order to support YUYV.
Please ignore this one. The driver already aligns (it enforces
an 8 pixels alignment... 2 pixels should be enough).
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
> drivers/media/platform/vim2m.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c
> index ab288e8377f1..89384f324e25 100644
> --- a/drivers/media/platform/vim2m.c
> +++ b/drivers/media/platform/vim2m.c
> @@ -801,7 +801,7 @@ static int vidioc_s_fmt(struct vim2m_ctx *ctx, struct v4l2_format *f)
> }
>
> q_data->fmt = find_format(f);
> - q_data->width = f->fmt.pix.width;
> + q_data->width = f->fmt.pix.width & (~1);
> q_data->height = f->fmt.pix.height;
> q_data->sizeimage = q_data->width * q_data->height
> * q_data->fmt->depth >> 3;
Thanks,
Mauro
next prev parent reply other threads:[~2019-02-26 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 17:36 [PATCH 1/2] media: vim2m: improve debug messages Mauro Carvalho Chehab
2019-02-26 17:36 ` [PATCH 2/2] media: vim2m: ensure that width is multiple of two Mauro Carvalho Chehab
2019-02-26 18:04 ` Mauro Carvalho Chehab [this message]
2019-02-27 12:13 ` [PATCH 1/2] media: vim2m: improve debug messages kbuild test robot
2019-02-27 12:55 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226150413.44afefb2@coco.lan \
--to=mchehab+samsung@kernel.org \
--cc=ezequiel@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox