public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@collabora.com>
To: linux-media@vger.kernel.org
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
	kernel@collabora.com, Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCH v2 0/4] Add debug messages to v4l2-ctrls
Date: Wed, 27 Feb 2019 14:07:02 -0300	[thread overview]
Message-ID: <20190227170706.6258-1-ezequiel@collabora.com> (raw)

v2:
  * Print the video device node name where possible, in v4l2-ctrls.c,
    by passing the struct video_device as a parameter.
  * Added a warning to dev_debug attribute store, to warn
    the user about V4L2_DEV_DEBUG_CTRL being a no-op for dev_debug.

Even though the goal was fairly simple (adding debug to v4l2-ctrls)
it ended up spanning this little patchset.

The motivation for this cleanup is being able to turn on/off
debugging messages in v4l2-ctrls.c, using a knob common to the
videodev driver's core.

So, in addition to the dev_debug attribute, this series introduces
a debug module parameter, and a new debug level, which enables
v4l2-ctrl debugging.

Having this is quite useful when bringing-up stateless codecs,
using the Request API.

Ezequiel Garcia (4):
  media: v4l: Simplify dev_debug flags
  media: v4l: Improve debug dprintk macro
  media: v4l: Add a module parameter to control global debugging
  media: v4l: ctrls: Add debug messages

 drivers/media/v4l2-core/v4l2-ctrls.c  | 93 +++++++++++++++++++++------
 drivers/media/v4l2-core/v4l2-dev.c    | 47 ++++++--------
 drivers/media/v4l2-core/v4l2-ioctl.c  |  8 +--
 drivers/media/v4l2-core/v4l2-subdev.c |  4 +-
 include/media/v4l2-ctrls.h            |  9 ++-
 include/media/v4l2-ioctl.h            |  2 +
 6 files changed, 110 insertions(+), 53 deletions(-)

-- 
2.20.1


             reply	other threads:[~2019-02-27 17:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-27 17:07 Ezequiel Garcia [this message]
2019-02-27 17:07 ` [PATCH v2 1/4] media: v4l: Simplify dev_debug flags Ezequiel Garcia
2019-03-11 11:16   ` Hans Verkuil
2019-05-28  0:09     ` Ezequiel Garcia
2019-02-27 17:07 ` [PATCH v2 2/4] media: v4l: Improve debug dprintk macro Ezequiel Garcia
2019-02-27 17:07 ` [PATCH v2 3/4] media: v4l: Add a module parameter to control global debugging Ezequiel Garcia
2019-02-27 17:07 ` [PATCH v2 4/4] media: v4l: ctrls: Add debug messages Ezequiel Garcia
2019-03-11 11:36   ` Hans Verkuil
2019-06-01 17:57     ` Ezequiel Garcia
2019-06-03  7:16       ` Hans Verkuil
2019-06-03 22:42         ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190227170706.6258-1-ezequiel@collabora.com \
    --to=ezequiel@collabora.com \
    --cc=hans.verkuil@cisco.com \
    --cc=kernel@collabora.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox