From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: hverkuil@xs4all.nl, mchehab@kernel.org, rajmohan.mani@intel.com
Subject: [PATCH v2 4/4] Revert "media: ipu3: shut up warnings produced with W=1"
Date: Fri, 1 Mar 2019 13:24:00 +0200 [thread overview]
Message-ID: <20190301112400.24339-5-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20190301112400.24339-1-sakari.ailus@linux.intel.com>
This reverts commit 0bdfc56c13c0ffe003f28395fcde2cd9b5ea0622.
The original patch suppressed compiler and checker warnings and those
warnings have been addressed. Do not attempt to suppress these warnings
anymore.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Tested-by: Rajmohan Mani <rajmohan.mani@intel.com>
---
drivers/staging/media/ipu3/Makefile | 6 ------
drivers/staging/media/ipu3/TODO | 2 --
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/media/ipu3/Makefile b/drivers/staging/media/ipu3/Makefile
index fa7fa3372bcbe..fb146d178bd4b 100644
--- a/drivers/staging/media/ipu3/Makefile
+++ b/drivers/staging/media/ipu3/Makefile
@@ -9,9 +9,3 @@ ipu3-imgu-objs += \
ipu3-css.o ipu3-v4l2.o ipu3.o
obj-$(CONFIG_VIDEO_IPU3_IMGU) += ipu3-imgu.o
-
-# HACK! While this driver is in bad shape, don't enable several warnings
-# that would be otherwise enabled with W=1
-ccflags-y += $(call cc-disable-warning, packed-not-aligned)
-ccflags-y += $(call cc-disable-warning, type-limits)
-ccflags-y += $(call cc-disable-warning, unused-const-variable)
diff --git a/drivers/staging/media/ipu3/TODO b/drivers/staging/media/ipu3/TODO
index 5e55baeaea1a3..8b95e74e43a0f 100644
--- a/drivers/staging/media/ipu3/TODO
+++ b/drivers/staging/media/ipu3/TODO
@@ -27,5 +27,3 @@ staging directory.
- Document different operation modes, and which buffer queues are relevant
in each mode. To process an image, which queues require a buffer an in
which ones is it optional?
-
-- Make sure it builds fine with no warnings with W=1
--
2.11.0
prev parent reply other threads:[~2019-03-01 11:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 11:23 [PATCH v2 0/4] Fix most ImgU driver compiler / checker warnings Sakari Ailus
2019-03-01 11:23 ` [PATCH v2 1/4] staging: imgu: Address a compiler warning on alignment Sakari Ailus
2019-05-27 16:44 ` Jacopo Mondi
2019-05-29 10:35 ` Sakari Ailus
2020-04-11 16:50 ` Tomasz Figa
2020-04-16 7:37 ` Sakari Ailus
2019-03-01 11:23 ` [PATCH v2 2/4] staging: imgu: Remove redundant checks Sakari Ailus
2019-03-01 11:23 ` [PATCH v2 3/4] staging: imgu: Address compiler / checker warnings in MMU code Sakari Ailus
2019-03-01 11:24 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301112400.24339-5-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rajmohan.mani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox