From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: hverkuil-cisco@xs4all.nl
Cc: linux-media@vger.kernel.org, Helen Koike <helen.koike@collabora.com>
Subject: Re: [PATCHv2 4/9] media-entity: set ent_enum->bmap to NULL after freeing it
Date: Tue, 5 Mar 2019 21:39:13 +0200 [thread overview]
Message-ID: <20190305193913.GF14928@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190305095847.21428-5-hverkuil-cisco@xs4all.nl>
Hi Hans,
Thank you for the patch.
On Tue, Mar 05, 2019 at 10:58:42AM +0100, hverkuil-cisco@xs4all.nl wrote:
> From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>
> Ensure that this pointer is set to NULL after it is freed.
> The vimc driver has a static media_entity and after
> unbinding and rebinding the vimc device the media code will
> try to free this pointer again since it wasn't set to NULL.
I still think the problem lies in the vimc driver. Reusing static
structures is really asking for trouble. I'm however not opposed to
merging this patch, as you mentioned the problem will be fixed in vimc
too. I still wonder, though, if merging this couldn't make it easier for
drivers to do the wrong thing.
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
> drivers/media/media-entity.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
> index 0b1cb3559140..7b2a2cc95530 100644
> --- a/drivers/media/media-entity.c
> +++ b/drivers/media/media-entity.c
> @@ -88,6 +88,7 @@ EXPORT_SYMBOL_GPL(__media_entity_enum_init);
> void media_entity_enum_cleanup(struct media_entity_enum *ent_enum)
> {
> kfree(ent_enum->bmap);
> + ent_enum->bmap = NULL;
> }
> EXPORT_SYMBOL_GPL(media_entity_enum_cleanup);
>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-03-05 19:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 9:58 [PATCHv2 0/9] Various core and virtual driver fixes hverkuil-cisco
2019-03-05 9:58 ` [PATCHv2 1/9] cec: fill in cec chardev kobject to ease debugging hverkuil-cisco
2019-03-05 9:58 ` [PATCHv2 2/9] media-devnode: fill in media " hverkuil-cisco
2019-03-05 9:58 ` [PATCHv2 3/9] vivid: use vzalloc for dev->bitmap_out hverkuil-cisco
2019-03-05 9:58 ` [PATCHv2 4/9] media-entity: set ent_enum->bmap to NULL after freeing it hverkuil-cisco
2019-03-05 19:39 ` Laurent Pinchart [this message]
2019-03-07 9:23 ` Hans Verkuil
2019-03-08 11:26 ` Laurent Pinchart
2019-03-08 13:59 ` Hans Verkuil
2019-03-05 9:58 ` [PATCHv2 5/9] vim2m: replace devm_kzalloc by kzalloc hverkuil-cisco
2019-03-05 9:58 ` [PATCHv2 6/9] v4l2-subdev: add release() internal op hverkuil-cisco
2019-03-05 19:46 ` Laurent Pinchart
2019-03-07 8:54 ` Hans Verkuil
2019-03-07 9:05 ` Laurent Pinchart
2019-03-05 9:58 ` [PATCHv2 7/9] v4l2-subdev: handle module refcounting here hverkuil-cisco
2019-03-05 19:52 ` Laurent Pinchart
2019-03-07 8:57 ` Hans Verkuil
2019-03-07 16:06 ` Sakari Ailus
2019-03-05 9:58 ` [PATCHv2 8/9] vimc: free vimc_cap_device when the last user disappears hverkuil-cisco
2019-03-05 9:58 ` [PATCHv2 9/9] vimc: use new release op hverkuil-cisco
2019-03-05 19:53 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305193913.GF14928@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox