From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A97B2C43381 for ; Sun, 10 Mar 2019 21:41:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D546207E0 for ; Sun, 10 Mar 2019 21:41:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="AhxEFmju" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726713AbfCJVlM (ORCPT ); Sun, 10 Mar 2019 17:41:12 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:39138 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726687AbfCJVlM (ORCPT ); Sun, 10 Mar 2019 17:41:12 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 03642255; Sun, 10 Mar 2019 22:41:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1552254069; bh=E2Jx/+xuKMu4h8eN3ync6LTfM2TdN76z1RlpoELovKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AhxEFmju163cBD4YB5G2OGgy4PZRxSP1C1y8Tj8/QrQ1R5bua5doRWMisQ9No1MJv zouDjp79YLdyg+IWlRxsgKc/YamvBJ9hewR0HjN5TZDoXV3I7g4AvGHnYn2fLuCR7x +RRUEq6sXdz9AaM3RO+U3YEdrnc5Oozkvxg03PPo= Date: Sun, 10 Mar 2019 23:41:02 +0200 From: Laurent Pinchart To: Rui Miguel Silva Cc: sakari.ailus@linux.intel.com, Steve Longerbeam , Hans Verkuil , Philipp Zabel , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v14 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections Message-ID: <20190310214102.GA7578@pendragon.ideasonboard.com> References: <20190206151328.21629-1-rui.silva@linaro.org> <20190206151328.21629-9-rui.silva@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190206151328.21629-9-rui.silva@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Rui, Thank you for the patch. On Wed, Feb 06, 2019 at 03:13:23PM +0000, Rui Miguel Silva wrote: > This patch adds the device tree nodes for csi, video multiplexer and > mipi-csi besides the graph connecting the necessary endpoints to make > the media capture entities to work in imx7 Warp board. > > Signed-off-by: Rui Miguel Silva > --- > arch/arm/boot/dts/imx7s-warp.dts | 51 ++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/imx7s.dtsi | 27 +++++++++++++++++ I would have split this in two patches to make backporting easier, but it's not a big deal. Please see below for a few additional comments. > 2 files changed, 78 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch/arm/boot/dts/imx7s-warp.dts > index 23431faecaf4..358bcae7ebaf 100644 > --- a/arch/arm/boot/dts/imx7s-warp.dts > +++ b/arch/arm/boot/dts/imx7s-warp.dts > @@ -277,6 +277,57 @@ > status = "okay"; > }; > > +&gpr { > + csi_mux { > + compatible = "video-mux"; > + mux-controls = <&mux 0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + reg = <1>; > + > + csi_mux_from_mipi_vc0: endpoint { > + remote-endpoint = <&mipi_vc0_to_csi_mux>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + > + csi_mux_to_csi: endpoint { > + remote-endpoint = <&csi_from_csi_mux>; > + }; > + }; > + }; > +}; > + > +&csi { > + status = "okay"; > + > + port { > + csi_from_csi_mux: endpoint { > + remote-endpoint = <&csi_mux_to_csi>; > + }; > + }; > +}; Shouldn't these two nodes, as well as port@1 of the mipi_csi node, be moved to imx7d.dtsi ? > + > +&mipi_csi { > + clock-frequency = <166000000>; > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; > + fsl,csis-hs-settle = <3>; Shouldn't this be an endpoint property ? Different sensors connected through different endpoints could have different timing requirements. > + > + port@1 { > + reg = <1>; > + > + mipi_vc0_to_csi_mux: endpoint { > + remote-endpoint = <&csi_mux_from_mipi_vc0>; > + }; > + }; > +}; > + > &wdog1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_wdog>; > diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi > index 792efcd2caa1..01962f85cab6 100644 > --- a/arch/arm/boot/dts/imx7s.dtsi > +++ b/arch/arm/boot/dts/imx7s.dtsi > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include "imx7d-pinfunc.h" > > / { > @@ -709,6 +710,17 @@ > status = "disabled"; > }; > > + csi: csi@30710000 { > + compatible = "fsl,imx7-csi"; > + reg = <0x30710000 0x10000>; > + interrupts = ; > + clocks = <&clks IMX7D_CLK_DUMMY>, > + <&clks IMX7D_CSI_MCLK_ROOT_CLK>, > + <&clks IMX7D_CLK_DUMMY>; > + clock-names = "axi", "mclk", "dcic"; > + status = "disabled"; > + }; > + > lcdif: lcdif@30730000 { > compatible = "fsl,imx7d-lcdif", "fsl,imx28-lcdif"; > reg = <0x30730000 0x10000>; > @@ -718,6 +730,21 @@ > clock-names = "pix", "axi"; > status = "disabled"; > }; > + > + mipi_csi: mipi-csi@30750000 { > + compatible = "fsl,imx7-mipi-csi2"; > + reg = <0x30750000 0x10000>; > + interrupts = ; > + clocks = <&clks IMX7D_IPG_ROOT_CLK>, > + <&clks IMX7D_MIPI_CSI_ROOT_CLK>, > + <&clks IMX7D_MIPI_DPHY_ROOT_CLK>; > + clock-names = "pclk", "wrap", "phy"; > + power-domains = <&pgc_mipi_phy>; > + phy-supply = <®_1p0d>; > + resets = <&src IMX7_RESET_MIPI_PHY_MRST>; > + reset-names = "mrst"; > + status = "disabled"; How about already declaring port@0 here too (but obviously without any endoint) ? > + }; > }; > > aips3: aips-bus@30800000 { -- Regards, Laurent Pinchart