From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mao Wenan <maowenan@huawei.com>
Cc: gregkh@linuxfoundation.org, Julia.Lawall@lip6.fr,
kimbrownkd@gmail.com, colin.king@canonical.com,
hans.verkuil@cisco.com, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()
Date: Mon, 11 Mar 2019 17:07:33 +0300 [thread overview]
Message-ID: <20190311140733.GG2434@kadam> (raw)
In-Reply-To: <20190311141405.123611-1-maowenan@huawei.com>
On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote:
> There is no need to have the 'T *v' variable static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
> index 6098f43ac51b..a2a672d4615d 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
> @@ -1881,7 +1881,7 @@ int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,
> struct v4l2_subdev *sd = &vpfe_rsz->crop_resizer.subdev;
> struct media_pad *pads = &vpfe_rsz->crop_resizer.pads[0];
> struct media_entity *me = &sd->entity;
> - static resource_size_t res_len;
> + resource_size_t res_len;
^
Could you remove the extra space character also, please.
> struct resource *res;
> int ret;
regards,
dan carpenter
next prev parent reply other threads:[~2019-03-11 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 14:14 [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init() Mao Wenan
2019-03-11 14:07 ` Dan Carpenter [this message]
2019-03-11 14:10 ` Colin Ian King
2019-03-11 14:37 ` Dan Carpenter
2019-03-11 14:17 ` maowenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311140733.GG2434@kadam \
--to=dan.carpenter@oracle.com \
--cc=Julia.Lawall@lip6.fr \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=kimbrownkd@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=maowenan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox