From: Ettore Chimenti <ek5.chimenti@gmail.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
Sylwester Nawrocki <snawrocki@kernel.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Thierry Reding <treding@nvidia.com>,
Wen Yang <wen.yang99@zte.com.cn>
Subject: Re: [PATCH 6/7] seco-cec: decrement HDMI device refcount
Date: Mon, 8 Apr 2019 15:21:40 +0200 [thread overview]
Message-ID: <20190408132138.GA8314@Ettosoft-T55> (raw)
In-Reply-To: <20190408110401.3345-7-hverkuil-cisco@xs4all.nl>
On Mon, Apr 08, 2019 at 01:04:00PM +0200, Hans Verkuil wrote:
> The SECO CEC driver never decremented the HDMI device refcount.
> CEC drivers only need the HDMI device pointer as a key in the
> notifier list, it never accesses the device, so there is no
> need to keep a reference.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Ettore Chimenti <ek5.chimenti@gmail.com>
Thanks,
Ettore
> ---
> drivers/media/platform/seco-cec/seco-cec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/seco-cec/seco-cec.c b/drivers/media/platform/seco-cec/seco-cec.c
> index a425a10540c1..e5080d6f5b2d 100644
> --- a/drivers/media/platform/seco-cec/seco-cec.c
> +++ b/drivers/media/platform/seco-cec/seco-cec.c
> @@ -536,6 +536,7 @@ static int secocec_cec_get_notifier(struct cec_notifier **notify)
> return -EPROBE_DEFER;
>
> *notify = cec_notifier_get_conn(d, m->conn);
> + put_device(d);
>
> return 0;
> }
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-04-08 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 11:03 [PATCH 0/7] cec: introduce cec_notifier_find_hdmi_dev helper Hans Verkuil
2019-04-08 11:03 ` [PATCH 1/7] cec-notifier: add " Hans Verkuil
2019-04-08 13:09 ` Thierry Reding
2019-04-08 13:17 ` Hans Verkuil
2019-04-08 11:03 ` [PATCH 2/7] meson: ao-cec: use new " Hans Verkuil
2019-04-08 12:01 ` Neil Armstrong
2019-04-08 11:03 ` [PATCH 3/7] s5p_cec: " Hans Verkuil
2019-04-08 11:03 ` [PATCH 4/7] stih_cec: " Hans Verkuil
2019-04-08 12:44 ` Benjamin Gaignard
2019-04-08 11:03 ` [PATCH 5/7] tegra_cec: " Hans Verkuil
2019-04-08 11:04 ` [PATCH 6/7] seco-cec: decrement HDMI device refcount Hans Verkuil
2019-04-08 13:21 ` Ettore Chimenti [this message]
2019-04-08 11:04 ` [PATCH 7/7] cros-ec-cec: " Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408132138.GA8314@Ettosoft-T55 \
--to=ek5.chimenti@gmail.com \
--cc=benjamin.gaignard@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=snawrocki@kernel.org \
--cc=treding@nvidia.com \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox