From: Boris Brezillon <boris.brezillon@collabora.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
linux-media@vger.kernel.org, kernel@collabora.com,
Tomasz Figa <tfiga@chromium.org>,
Hirokazu Honda <hiroh@chromium.org>,
Nicolas Dufresne <nicolas@ndufresne.ca>
Subject: Re: [PATCH v3 1/2] media: exynos4-is: Properly report _MPLANE caps
Date: Fri, 12 Apr 2019 12:24:01 +0200 [thread overview]
Message-ID: <20190412122401.722bdf63@collabora.com> (raw)
In-Reply-To: <c1faa661-6631-00ae-836b-4f24b1ee408e@samsung.com>
On Fri, 12 Apr 2019 12:16:42 +0200
Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:
> Hi,
>
> On 4/12/19 11:20, Boris Brezillon wrote:
> > The fimc-isp-video.c and fimc-lite.c were missing the
> > V4L2_CAP_VIDEO_CAPTURE_MPLANE flag when reporting device caps.
>
> Th omission was intentional, as these video nodes cannot be used
> by "standard" V4L2 capture applications. Some sub-devices need to
> be configured first in order to use these video nodes. It was
> agreed to not set these capabilities in the driver, instead user
> space library, e.g. libv4l2 with driver-specific plugin handling
> the media controller and v4l2 subdev calls would set the capability
> for the applications. Has something changed?
>
Hm, maybe I should just drop the extra consistency check I added in
v4l_enum_fmt() and call ->vidioc_enum_fmt_vid_{cap,out}()
unconditionally.
next prev parent reply other threads:[~2019-04-12 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190412092035epcas1p43412936a0fba75b1c548904e785fe23d@epcas1p4.samsung.com>
2019-04-12 9:20 ` [PATCH v3 1/2] media: exynos4-is: Properly report _MPLANE caps Boris Brezillon
2019-04-12 9:20 ` [PATCH v3 2/2] media: v4l2: Get rid of ->vidioc_enum_fmt_vid_{cap,out}_mplane Boris Brezillon
2019-04-12 9:31 ` [PATCH v3 1/2] media: exynos4-is: Properly report _MPLANE caps Hans Verkuil
2019-04-12 10:16 ` Sylwester Nawrocki
2019-04-12 10:24 ` Boris Brezillon [this message]
2019-04-12 10:32 ` Hans Verkuil
2019-04-12 11:14 ` Sylwester Nawrocki
2019-04-18 22:35 ` Laurent Pinchart
2019-04-30 12:29 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412122401.722bdf63@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=hans.verkuil@cisco.com \
--cc=hiroh@chromium.org \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@iki.fi \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox