From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Nicolas Dufresne <nicolas@ndufresne.ca>,
Andrzej Hajda <a.hajda@samsung.com>,
Marian Mihailescu <mihailescu2m@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
JaeChul Lee <jcsing.lee@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Seung-Woo Kim <sw0312.kim@samsung.com>
Subject: Re: [PATCH v2] media: s5p-mfc: Add support for V4L2_MEMORY_DMABUF type
Date: Wed, 29 May 2019 15:31:53 -0300 [thread overview]
Message-ID: <20190529153153.13b1e939@coco.lan> (raw)
In-Reply-To: <c894f9b6-5381-b7eb-ba77-35e71958bf45@samsung.com>
Em Mon, 18 Dec 2017 09:19:11 +0100
Marek Szyprowski <m.szyprowski@samsung.com> escreveu:
> Hi Hans,
>
> On 2017-12-15 16:57, Hans Verkuil wrote:
> > On 14/12/17 15:11, Marek Szyprowski wrote:
> >> I would like to get your opinion on this patch. Do you think it makes sense to:
> >>
> >> 1. add limited support for USERPTR and DMA-buf import? (limited means driver will accept setting buffer pointer/fd only once after reqbufs for each buffer index)
> > I don't like this. It's unexpected almost-but-not-quite behavior that will make
> > life very difficult for userspace.
> >
> >> 2. add a V4L2 device flag to let userspace to discover if device support queue buffer reconfiguration on-fly or not?
> > This seems to me a better approach. It should be possible to implement most/all of this
> > in vb2, but we need to find a way to signal this to the user.
>
> Okay, I will prepare a patch with such flag soon.
>
> > Is this an MFC limitation for the decoder, encoder or both? And is it a limitation
> > of the capture or output side or both?
>
> Both and both. DMA addresses of all buffers must be known while
> initializing decoder
> and encoder.
>
> > ...
>
> Best regards
Marek/Sylwester,
What's the status of this one? The patch still applies (with a minor
conflict).
Thanks,
Mauro
prev parent reply other threads:[~2019-05-29 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171103081132eucas1p2212e32d26e7921340336d78d0d92cb1b@eucas1p2.samsung.com>
2017-11-03 8:11 ` [PATCH v2] media: s5p-mfc: Add support for V4L2_MEMORY_DMABUF type Marek Szyprowski
2017-11-03 13:45 ` Nicolas Dufresne
2017-11-03 15:20 ` Tobias Jakobi
2017-11-03 15:28 ` Tobias Jakobi
2017-11-06 9:28 ` Marek Szyprowski
2017-11-06 19:21 ` Nicolas Dufresne
2017-12-14 14:11 ` Marek Szyprowski
2017-12-15 15:57 ` Hans Verkuil
2017-12-18 8:19 ` Marek Szyprowski
2019-05-29 18:31 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529153153.13b1e939@coco.lan \
--to=mchehab+samsung@kernel.org \
--cc=a.hajda@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=hverkuil@xs4all.nl \
--cc=jcsing.lee@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mihailescu2m@gmail.com \
--cc=nicolas@ndufresne.ca \
--cc=s.nawrocki@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).