Re: [PATCH v5 4/4] pvrusb2: Add Hauppauge HVR1955/1975 devices

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2640 bytes --]

Hi Brad,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.2-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Brad-Love/Add-Hauppauge-HVR1955-1975-devices/20190602-191815
base:   git://linuxtv.org/media_tree.git master
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/media/usb/pvrusb2/pvrusb2-devattr.c:649:23: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
      .fx2_firmware.lst = pvr2_fw1_names_160xxx,
                          ^~~~~~~~~~~~~~~~~~~~~
   drivers/media/usb/pvrusb2/pvrusb2-devattr.c:673:23: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
      .fx2_firmware.lst = pvr2_fw1_names_160xxx,
                          ^~~~~~~~~~~~~~~~~~~~~

vim +/const +649 drivers/media/usb/pvrusb2/pvrusb2-devattr.c

   643	
   644	static const struct pvr2_device_desc pvr2_device_160000 = {
   645			.description = "WinTV HVR-1975 Model 160000",
   646			.shortname = "160000",
   647			.client_table.lst = pvr2_cli_160xxx,
   648			.client_table.cnt = ARRAY_SIZE(pvr2_cli_160xxx),
 > 649			.fx2_firmware.lst = pvr2_fw1_names_160xxx,
   650			.fx2_firmware.cnt = ARRAY_SIZE(pvr2_fw1_names_160xxx),
   651			.default_tuner_type = TUNER_ABSENT,
   652			.flag_has_cx25840 = 1,
   653			.flag_has_hauppauge_rom = 1,
   654			.flag_has_analogtuner = 1,
   655			.flag_has_composite = 1,
   656			.flag_has_svideo = 1,
   657			.flag_fx2_16kb = 1,
   658			.signal_routing_scheme = PVR2_ROUTING_SCHEME_HAUPPAUGE,
   659			.digital_control_scheme = PVR2_DIGITAL_SCHEME_HAUPPAUGE,
   660			.default_std_mask = V4L2_STD_NTSC_M,
   661			.led_scheme = PVR2_LED_SCHEME_HAUPPAUGE,
   662			.ir_scheme = PVR2_IR_SCHEME_ZILOG,
   663	#ifdef CONFIG_VIDEO_PVRUSB2_DVB
   664			.dvb_props = &pvr2_160000_dvb_props,
   665	#endif
   666	};
   667	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 58652 bytes --]