Re: [PATCH v16 16/16] selftests, arm64: add a selftest for passing tagged pointers to kernel

shuah
2019-06-10T22:08:18Z

On 6/7/19 9:56 PM, Kees Cook wrote:
> On Mon, Jun 03, 2019 at 06:55:18PM +0200, Andrey Konovalov wrote:
>> This patch is a part of a series that extends arm64 kernel ABI to allow to
>> pass tagged user pointers (with the top byte set to something else other
>> than 0x00) as syscall arguments.
>>
>> This patch adds a simple test, that calls the uname syscall with a
>> tagged user pointer as an argument. Without the kernel accepting tagged
>> user pointers the test fails with EFAULT.
>>
>> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
>
> I'm adding Shuah to CC in case she has some suggestions about the new
> selftest.

Thanks Kees.

>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> -Kees
>

Looks good to me.

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah