public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@collabora.com>
To: linux-media@vger.kernel.org, Hans Verkuil <hans.verkuil@cisco.com>
Cc: kernel@collabora.com,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Pawel Osciak <pawel@osciak.com>,
	Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCH v2 1/5] media: vb2: Introduce a vb2_get_buffer accessor
Date: Mon, 10 Jun 2019 17:55:22 -0300	[thread overview]
Message-ID: <20190610205526.2629-2-ezequiel@collabora.com> (raw)
In-Reply-To: <20190610205526.2629-1-ezequiel@collabora.com>

Some drivers need to access a vb2 buffer from its
queue index. Introduce an accessor to abstract this,
and avoid drivers from accessing private members.

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
Changes from v1:
* Drop redundant num_buffers > 0 check.
---
 include/media/videobuf2-core.h | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index c03ef7cc5071..640aabe69450 100644
--- a/include/media/videobuf2-core.h
+++ b/include/media/videobuf2-core.h
@@ -1163,6 +1163,24 @@ static inline void vb2_clear_last_buffer_dequeued(struct vb2_queue *q)
 	q->last_buffer_dequeued = false;
 }
 
+/**
+ * vb2_get_buffer() - get a buffer from a queue
+ * @q:		pointer to &struct vb2_queue with videobuf2 queue.
+ * @index:	buffer index
+ *
+ * This function obtains a buffer from a queue, by its index.
+ * Keep in mind that there is no refcounting involved in this
+ * operation, so the buffer lifetime should be taken into
+ * consideration.
+ */
+static inline struct vb2_buffer *vb2_get_buffer(struct vb2_queue *q,
+						unsigned int index)
+{
+	if (index < q->num_buffers)
+		return q->bufs[index];
+	return NULL;
+}
+
 /*
  * The following functions are not part of the vb2 core API, but are useful
  * functions for videobuf2-*.
-- 
2.20.1


  reply	other threads:[~2019-06-10 20:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10 20:55 [PATCH v2 0/5] media: Access videobuf2 buffers via an accessor Ezequiel Garcia
2019-06-10 20:55 ` Ezequiel Garcia [this message]
2019-06-11 12:27   ` [PATCH v2 1/5] media: vb2: Introduce a vb2_get_buffer accessor Marek Szyprowski
2019-06-10 20:55 ` [PATCH v2 2/5] media: mtk-jpeg: Use vb2_get_buffer Ezequiel Garcia
2019-06-10 20:55 ` [PATCH v2 3/5] media: mtk-vcodec: " Ezequiel Garcia
2019-06-10 20:55 ` [PATCH v2 4/5] media: sti: " Ezequiel Garcia
2019-06-10 20:55 ` [PATCH v2 5/5] media: rockchip: " Ezequiel Garcia
2019-06-14  7:40   ` Hans Verkuil
2019-06-18 23:12     ` [PATCH] media: hantro: " Ezequiel Garcia
2019-06-21 21:03       ` kbuild test robot
2019-06-22  4:14       ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190610205526.2629-2-ezequiel@collabora.com \
    --to=ezequiel@collabora.com \
    --cc=boris.brezillon@collabora.com \
    --cc=hans.verkuil@cisco.com \
    --cc=kernel@collabora.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=pawel@osciak.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox