From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
Florian Echtler <floe@butterbrot.org>
Subject: Re: [PATCH] input/touchscreen/sur40: use COLORSPACE_RAW
Date: Sun, 30 Jun 2019 00:23:26 -0700 [thread overview]
Message-ID: <20190630072326.GE91171@dtor-ws> (raw)
In-Reply-To: <25bfb7ad-0c12-3d47-81b1-6feb1906cd42@xs4all.nl>
On Wed, Jun 26, 2019 at 11:52:16AM +0200, Hans Verkuil wrote:
> This driver set the colorspace to SRGB, but that makes no sense for
> a touchscreen. Use RAW instead. This also ensures consistency with the
> v4l_pix_format_touch() call that's used in v4l2-ioctl.c.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
> Dmitry, do you want to take this, or shall I? I have no preference.
Please take it.
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index 00cb1ba2d364..3fd3e862269b 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -186,7 +186,7 @@ static const struct v4l2_pix_format sur40_pix_format[] = {
> .width = SENSOR_RES_X / 2,
> .height = SENSOR_RES_Y / 2,
> .field = V4L2_FIELD_NONE,
> - .colorspace = V4L2_COLORSPACE_SRGB,
> + .colorspace = V4L2_COLORSPACE_RAW,
> .bytesperline = SENSOR_RES_X / 2,
> .sizeimage = (SENSOR_RES_X/2) * (SENSOR_RES_Y/2),
> },
> @@ -195,7 +195,7 @@ static const struct v4l2_pix_format sur40_pix_format[] = {
> .width = SENSOR_RES_X / 2,
> .height = SENSOR_RES_Y / 2,
> .field = V4L2_FIELD_NONE,
> - .colorspace = V4L2_COLORSPACE_SRGB,
> + .colorspace = V4L2_COLORSPACE_RAW,
> .bytesperline = SENSOR_RES_X / 2,
> .sizeimage = (SENSOR_RES_X/2) * (SENSOR_RES_Y/2),
> }
--
Dmitry
prev parent reply other threads:[~2019-06-30 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 9:52 [PATCH] input/touchscreen/sur40: use COLORSPACE_RAW Hans Verkuil
2019-06-27 8:12 ` Florian Echtler
2019-06-27 8:20 ` Hans Verkuil
2019-06-28 7:17 ` Florian Echtler
2019-06-30 7:23 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190630072326.GE91171@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=floe@butterbrot.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox