Re: [PATCH v3 2/3] media: uapi: h264: Add the concept of decoding mode

Paul Kocialkowski
2019-07-25T19:20:21Z

Hi,

On Wed 03 Jul 19, 14:28, Boris Brezillon wrote:
> @@ -125,6 +134,10 @@ struct v4l2_h264_pred_weight_table {
> struct v4l2_ctrl_h264_slice_params {
> /* Size in bytes, including header */
> __u32 size;
> +
> + /* Where the slice starts in the output buffer (expressed in bytes). */
> + __u32 start_byte_offset;
> +

As I understood, we would also need to specify the beginning of the slice
relative to the beginning of the start code so we don't have to assume
fixed-size start codes or have to do the parsing in the kernel.

This can certainly be done as a subsequent patch/series, and definitely not
necessarily by you (don't want to add more on your shoulders at this point)!

Cheers,

Paul

> /* Offset in bits to slice_data() from the beginning of this slice. */
> __u32 header_bit_size;
>
> --
> 2.21.0
>

--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering