From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43941C76190 for ; Thu, 25 Jul 2019 19:38:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 193D1218EA for ; Thu, 25 Jul 2019 19:38:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726251AbfGYTiK (ORCPT ); Thu, 25 Jul 2019 15:38:10 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:43389 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726177AbfGYTiK (ORCPT ); Thu, 25 Jul 2019 15:38:10 -0400 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id B893F240006; Thu, 25 Jul 2019 19:38:06 +0000 (UTC) Date: Thu, 25 Jul 2019 21:38:06 +0200 From: Paul Kocialkowski To: Boris Brezillon Cc: Tomasz Figa , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Sakari Ailus , Linux Media Mailing List , Nicolas Dufresne , kernel@collabora.com, Maxime Ripard , Ezequiel Garcia , Jonas Karlman , Jernej Skrabec , Alexandre Courbot , Thierry Reding Subject: Re: [PATCH v3 3/3] media: uapi: h264: Get rid of the p0/b0/b1 ref-lists Message-ID: <20190725193806.GE14499@aptenodytes> References: <20190703122849.6316-1-boris.brezillon@collabora.com> <20190703122849.6316-4-boris.brezillon@collabora.com> <20190724074624.508388aa@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190724074624.508388aa@collabora.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, On Wed 24 Jul 19, 07:46, Boris Brezillon wrote: > On Wed, 24 Jul 2019 12:39:55 +0900 > Tomasz Figa wrote: > > > Hi Boris, > > > > On Wed, Jul 3, 2019 at 9:28 PM Boris Brezillon > > wrote: > > > > > > Those lists can be extracted from the dpb, let's simplify userspace > > > life and build that list kernel-side (generic helpers will be provided > > > for drivers that need this list). > > > > > > Signed-off-by: Boris Brezillon > > > --- > > > Changes in v3: > > > * None > > > > > > Changes in v2: > > > * None > > > --- > > > Documentation/media/uapi/v4l/ext-ctrls-codec.rst | 9 --------- > > > 1 file changed, 9 deletions(-) > > > > > > diff --git a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst > > > index 47ba2d057a92..237c8e8e6bca 100644 > > > --- a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst > > > +++ b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst > > > @@ -1946,15 +1946,6 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type - > > > * - __u16 > > > - ``nal_ref_idc`` > > > - NAL reference ID value coming from the NAL Unit header > > > - * - __u8 > > > - - ``ref_pic_list_p0[32]`` > > > - - Backward reference list used by P-frames in the original bitstream order > > > - * - __u8 > > > - - ``ref_pic_list_b0[32]`` > > > - - Backward reference list used by B-frames in the original bitstream order > > > - * - __u8 > > > - - ``ref_pic_list_b1[32]`` > > > - - Forward reference list used by B-frames in the original bitstream order > > > * - __s32 > > > - ``top_field_order_cnt`` > > > - Picture Order Count for the coded top field > > > > Thanks for the patch. > > > > Don't we also need to remove these fields from the UAPI structs? > > Oops, indeed. I'll drop them in the next version. With that change, feel free to add my: Reviewed-by: Paul Kocialkowski Cheers and thanks! Paul -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com