linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] mach-omap2/devices.c: set dma mask
Date: Mon, 12 Aug 2019 05:54:40 -0700	[thread overview]
Message-ID: <20190812125440.GD52127@atomide.com> (raw)
In-Reply-To: <3c9077dc-3092-43b6-d58f-de9983da6c44@xs4all.nl>

* Hans Verkuil <hverkuil@xs4all.nl> [190812 12:50]:
> On 7/30/19 8:17 AM, Hans Verkuil wrote:
> > The dma_mask and coherent_dma_mask values were never set.
> > 
> > This prevented the media omap_vout driver from loading successfully.
> > 
> > Tested on a Pandaboard and Beagle XM board.
> > 
> > Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> 
> Tony, can you pick this up? Or give an Ack so that it can be merged via
> the media subsystem if you prefer?

Sorry for the delays on this one. Please just merge
it via via the media susbsystem since you need it:

Acked-by: Tony Lindgren <tony@atomide.com>

> > ---
> >  arch/arm/mach-omap2/devices.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> > index cc0d08dad141..5a2e198e7db1 100644
> > --- a/arch/arm/mach-omap2/devices.c
> > +++ b/arch/arm/mach-omap2/devices.c
> > @@ -10,6 +10,7 @@
> >  #include <linux/platform_device.h>
> >  #include <linux/io.h>
> >  #include <linux/clk.h>
> > +#include <linux/dma-mapping.h>
> >  #include <linux/err.h>
> >  #include <linux/slab.h>
> >  #include <linux/of.h>
> > @@ -43,11 +44,17 @@ static struct resource omap_vout_resource[2] = {
> >  };
> >  #endif
> > 
> > +static u64 omap_vout_dma_mask = DMA_BIT_MASK(32);
> > +
> >  static struct platform_device omap_vout_device = {
> >  	.name		= "omap_vout",
> >  	.num_resources	= ARRAY_SIZE(omap_vout_resource),
> >  	.resource 	= &omap_vout_resource[0],
> >  	.id		= -1,
> > +	.dev		= {
> > +		.dma_mask		= &omap_vout_dma_mask,
> > +		.coherent_dma_mask	= DMA_BIT_MASK(32),
> > +	},
> >  };
> > 
> >  int __init omap_init_vout(void)
> > 
> 

      reply	other threads:[~2019-08-12 12:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30  6:17 [PATCH] mach-omap2/devices.c: set dma mask Hans Verkuil
2019-08-12 12:49 ` Hans Verkuil
2019-08-12 12:54   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190812125440.GD52127@atomide.com \
    --to=tony@atomide.com \
    --cc=hverkuil@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).