From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04464C433FF for ; Thu, 15 Aug 2019 06:57:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D295B2133F for ; Thu, 15 Aug 2019 06:57:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730220AbfHOG5o (ORCPT ); Thu, 15 Aug 2019 02:57:44 -0400 Received: from mga05.intel.com ([192.55.52.43]:42097 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729838AbfHOG5o (ORCPT ); Thu, 15 Aug 2019 02:57:44 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2019 23:57:43 -0700 X-IronPort-AV: E=Sophos;i="5.64,388,1559545200"; d="scan'208";a="201126314" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2019 23:57:42 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 7EAB32069D; Thu, 15 Aug 2019 09:56:35 +0300 (EEST) Date: Thu, 15 Aug 2019 09:56:35 +0300 From: Sakari Ailus To: Jacopo Mondi Cc: Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" , open list , devicetree@vger.kernel.org Subject: Re: [RFC 1/5] media: dt-bindings: Document 'location' property Message-ID: <20190815065635.GJ6133@paasikivi.fi.intel.com> References: <20190814202815.32491-1-jacopo@jmondi.org> <20190814202815.32491-2-jacopo@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814202815.32491-2-jacopo@jmondi.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Jacopo, On Wed, Aug 14, 2019 at 10:28:11PM +0200, Jacopo Mondi wrote: > Add the 'location' device property, used to specify the camera device > mounting position. The property is particularly meaningful for mobile > devices with a well defined usage orientation. > > Signed-off-by: Jacopo Mondi > --- > Documentation/devicetree/bindings/media/video-interfaces.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt > index f884ada0bffc..819077b2649c 100644 > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > @@ -89,6 +89,10 @@ Optional properties > but a number of degrees counter clockwise. Typical values are 0 and 180 > (upside down). > > +- location: The camera device mounting position, relative to the device > + usage orientation. Possible values are: > + 0 - Front camera. The image sensor is mounted on the front side of the device. > + 1 - Back camera. The image sensor is mounted on the back side of the device. Would it make sense to make this a little more generic? Such as s/image sensor/ device/, for instance? Is this also relevant for flash or lens devices? Flash (torch) devices could be present, at least principle, without a camera. There once was even such a Nokia phone, 1100 unless I'm mistaken. :-) -- Regards, Sakari Ailus sakari.ailus@linux.intel.com