From: Steve Longerbeam <slongerbeam@gmail.com>
To: linux-media@vger.kernel.org
Cc: Steve Longerbeam <slongerbeam@gmail.com>
Subject: [PATCH 0/2] media: imx: Fix subdev unregister/register issues
Date: Fri, 23 Aug 2019 17:27:48 -0700 [thread overview]
Message-ID: <20190824002750.5860-1-slongerbeam@gmail.com> (raw)
If the media device module is removed and re-probed without also removing
and re-probing the subdevice modules, .unregister() and .register() ops
are called on the subdevices without the subdevice drivers being removed
and re-probed. This creates two problems:
- the CSI and PRPENCVF subdevices attempt to register a stale video capture
device resulting in the kobject "tried to init an initialized object"
backtrace.
- pad graph objects are added to the media device pad list twice, resulting
in list corruption on the pad list.
The following two patches fix those issues.
Steve Longerbeam (2):
media: imx: Move capture device init to registered
media: imx: Move pads init to probe
drivers/staging/media/imx/imx-ic-prp.c | 25 ++++-----
drivers/staging/media/imx/imx-ic-prpencvf.c | 51 ++++++++++---------
drivers/staging/media/imx/imx-media-capture.c | 15 +++---
drivers/staging/media/imx/imx-media-csi.c | 35 +++++++------
drivers/staging/media/imx/imx-media-vdic.c | 27 ++++------
drivers/staging/media/imx/imx6-mipi-csi2.c | 27 +++++-----
drivers/staging/media/imx/imx7-media-csi.c | 38 +++++++-------
drivers/staging/media/imx/imx7-mipi-csis.c | 23 +++------
8 files changed, 114 insertions(+), 127 deletions(-)
--
2.17.1
next reply other threads:[~2019-08-24 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 0:27 Steve Longerbeam [this message]
2019-08-24 0:27 ` [PATCH 1/2] media: imx: Move capture device init to registered Steve Longerbeam
2019-08-24 11:25 ` kbuild test robot
2019-08-24 0:27 ` [PATCH 2/2] media: imx: Move pads init to probe Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824002750.5860-1-slongerbeam@gmail.com \
--to=slongerbeam@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox