linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tskd08@gmail.com
To: linux-media@vger.kernel.org
Cc: crope@iki.fi, sean@mess.org, mchehab@kernel.org,
	Akihiro Tsukada <tskd08@gmail.com>
Subject: [PATCH 0/2] dvb-usb-gl861: remove device-specific i2c algo
Date: Wed, 28 Aug 2019 00:01:39 +0900	[thread overview]
Message-ID: <20190827150141.10240-1-tskd08@gmail.com> (raw)

From: Akihiro Tsukada <tskd08@gmail.com>

This patch series removes and integrates the device(Friio)-specific
i2c algo with the other, generic one that was recently patched
( https://patchwork.linuxtv.org/patch/58340/ )
to support the i2c messages used in Friio, for reading/writing to tuner.

To fully complete the integration,
users of this i2c alog (in this case, i2c adapter in demod tc90522)
must be modified to divide each tuner read transaction into two.
I had implemented this modification (and the config option to enable it)
in tc90522 (and in gl861, to use the config option), and tested it,
which verified that a Friio device can properly read tuner status,
(and write/set frequency as well) without problems.
Although there was a concern over small in-compatibility
of the generic i2c algo with the old devcie-specific algo in tuner reads,
(as described in https://patchwork.linuxtv.org/patch/58340/#111873 )
it had been cleared by the testing.

But for now I do not include the patch to tc90522,
because it just adds tuner read capablity,
and the tuner in Friio just supports reading its status (PLL lock status)
which is not particularly useful.
Besides, the current tuner driver (dvb-pll) does not implement any readings.
So I would rather spare the modification in exchange for simplicity,
until future devices that use gl861, tc90522 and a tuner with RSSI reading
come up.

Akihiro Tsukada (2):
  dvb-usb-v2/gl861: remove device-specific i2c algo and use generic one
  dvb-usb-v2/gl861: remove un-used header file

 drivers/media/usb/dvb-usb-v2/gl861.c | 236 +++------------------------
 drivers/media/usb/dvb-usb-v2/gl861.h |  14 --
 2 files changed, 27 insertions(+), 223 deletions(-)
 delete mode 100644 drivers/media/usb/dvb-usb-v2/gl861.h

-- 
2.23.0


             reply	other threads:[~2019-08-27 15:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 15:01 tskd08 [this message]
2019-08-27 15:01 ` [PATCH 1/2] dvb-usb-v2/gl861: remove device-specific i2c algo tskd08
2019-08-27 15:01 ` [PATCH 2/2] dvb-usb-v2/gl861: remove un-used header file tskd08

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190827150141.10240-1-tskd08@gmail.com \
    --to=tskd08@gmail.com \
    --cc=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sean@mess.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).