Re: [RFC,v2 3/6] media: dt-bindings: add DS90UB954-Q1 video deserializer

Luca Ceresoli
2019-09-10T15:02:53Z

Hi Sakari,

On 10/09/19 10:43, Sakari Ailus wrote:
> Hi Luca,
>
> On Tue, Jul 23, 2019 at 10:37:20PM +0200, Luca Ceresoli wrote:
>
> ...
>
>> +Device node example
>> +-------------------
>> +
>> +&i2c0 {
>> + deser: deser@3d {
>> + compatible = "ti,ds90ub954-q1";
>> + reg-names = "main", "rxport0", "rxport1", "ser0", "ser1";
>> + reg = <0x3d>, <0x40>, <0x41>, <0x44>, <0x45>;
>> + clocks = <&clk_25M>;
>> + interrupt-parent = <&gic>;
>> + interrupts = <3 1 IRQ_TYPE_LEVEL_HIGH>;
>> + reset-gpios = <&gpio_ctl 4 GPIO_ACTIVE_LOW>;
>> +
>> + i2c-alias-pool = /bits/ 16 <0x4a 0x4b 0x4c 0x4d 0x4e 0x4f>;
>> +
>> + gpio-controller;
>> + #gpio-cells = <3>; /* rxport, remote gpio num, flags */
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + ds90ub954_fpd3_in0: endpoint {
>> + remote-endpoint = <&sensor_0_out>;
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> + ds90ub954_fpd3_in1: endpoint {
>> + remote-endpoint = <&sensor_1_out>;
>> + };
>> + };
>> +
>> + port@2 {
>> + reg = <2>;
>> + ds90ub954_mipi_out0: endpoint {
>> + data-lanes = <1 2 3 4>;
>> + /* Actually a REFCLK multiplier */
>> + data-rate = <1600000000>;
>
> What is data-rate used for? Is it documented somewhere? Could you use
> link-frequencies property instead? It's defined in video-interfaces.txt.

Right, it should be link-frequencies. Thanks for pointing out.

--
Luca