From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E7DC3A5A5 for ; Thu, 5 Sep 2019 10:40:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A57722CF5 for ; Thu, 5 Sep 2019 10:40:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387987AbfIEKkJ (ORCPT ); Thu, 5 Sep 2019 06:40:09 -0400 Received: from mga14.intel.com ([192.55.52.115]:21688 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731981AbfIEKkI (ORCPT ); Thu, 5 Sep 2019 06:40:08 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 03:40:08 -0700 X-IronPort-AV: E=Sophos;i="5.64,470,1559545200"; d="scan'208";a="173900646" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 03:40:03 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 8A12D20584; Thu, 5 Sep 2019 13:40:01 +0300 (EEST) Date: Thu, 5 Sep 2019 13:40:01 +0300 From: Sakari Ailus To: Andy Shevchenko Cc: Javier Martinez Canillas , dongchun.zhu@mediatek.com, mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, drinkcat@chromium.org, tfiga@chromium.org, matthias.bgg@gmail.com, bingbu.cao@intel.com, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, sj.huang@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, sam.hung@mediatek.com, shengnan.wang@mediatek.com Subject: Re: [V2, 2/2] media: i2c: Add DW9768 VCM driver Message-ID: <20190905104001.GZ5475@paasikivi.fi.intel.com> References: <20190905072142.14606-1-dongchun.zhu@mediatek.com> <20190905072142.14606-3-dongchun.zhu@mediatek.com> <20190905082134.GY5475@paasikivi.fi.intel.com> <20190905101908.GB2680@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190905101908.GB2680@smile.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Sep 05, 2019 at 01:19:08PM +0300, Andy Shevchenko wrote: > On Thu, Sep 05, 2019 at 11:21:34AM +0300, Sakari Ailus wrote: > > On Thu, Sep 05, 2019 at 03:21:42PM +0800, dongchun.zhu@mediatek.com wrote: > > > From: Dongchun Zhu > > > > +static const struct i2c_device_id dw9768_id_table[] = { > > > + { DW9768_NAME, 0 }, > > > + { }, > > > > Could you drop the I²C ID table? > > But why? > It will allow you to instanciate the device from user space. The device is supposed to be present in DT (or ACPI tables) already. > > +Cc: Javier. > > Javier, is it needed in new code? -- Sakari Ailus sakari.ailus@linux.intel.com