From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: zhengbin <zhengbin13@huawei.com>,
mchehab@kernel.org, linux-media@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH v2] media: mc-device.c: fix memleak in media_device_register_entity
Date: Fri, 6 Sep 2019 13:36:02 +0300 [thread overview]
Message-ID: <20190906103602.GA5028@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190906101134.GK5475@paasikivi.fi.intel.com>
Hi Sakari,
On Fri, Sep 06, 2019 at 01:11:34PM +0300, Sakari Ailus wrote:
> On Fri, Sep 06, 2019 at 12:12:03PM +0300, Laurent Pinchart wrote:
> > On Mon, Aug 19, 2019 at 09:51:30AM +0800, zhengbin wrote:
> > > In media_device_register_entity, if media_graph_walk_init fails,
> > > need to free the previously memory.
> > >
> > > Reported-by: Hulk Robot <hulkci@huawei.com>
> > > Signed-off-by: zhengbin <zhengbin13@huawei.com>
> >
> > This looks good to me.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > and applied to my tree, for v5.5.
>
> Hmm. This is in my tree as well. Would you like to drop it from yours? :-)
Sure :-)
I wonder if we should setup a shared git tree for this.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-09-06 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 1:51 [PATCH v2] media: mc-device.c: fix memleak in media_device_register_entity zhengbin
2019-09-04 8:46 ` zhengbin (A)
2019-09-06 9:12 ` Laurent Pinchart
2019-09-06 10:11 ` Sakari Ailus
2019-09-06 10:36 ` Laurent Pinchart [this message]
2019-09-06 10:59 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906103602.GA5028@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=yi.zhang@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox