Re: [PATCH 5/6] media: sun4i: Add H3 deinterlace driver

Jernej Škrabec
2019-09-13T20:06:25Z

Hi!

Dne petek, 13. september 2019 ob 11:11:47 CEST je Maxime Ripard napisal(a):
> Hi,
>
> On Thu, Sep 12, 2019 at 10:43:28PM +0200, Jernej Škrabec wrote:
> > Dne četrtek, 12. september 2019 ob 22:26:47 CEST je Maxime Ripard
napisal(a):
> > > > + clk_set_rate(dev->mod_clk, 300000000);
>
> I just realized I missed this too. If you really need the rate to be
> fixed, and if the controller cannot operate properly at any other
> frequency, you probably want to use clk_set_rate_exclusive there.

I don't think that's needed. Parents of deinterlace clock are pll-periph0 and
pll-periph1 which both have fixed clock and thus deinterlace clock will never
be changed. I just set it to same frequency as it is set in BSP driver. I
think it works with 600 MHz too, but that's overkill.

Best regards,
Jernej