linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Sasha Levin <sashal@kernel.org>,
	linux-media@vger.kernel.org
Subject: [PATCH AUTOSEL 5.2 075/185] media: omap3isp: Don't set streaming state on random subdevs
Date: Sun, 22 Sep 2019 14:47:33 -0400	[thread overview]
Message-ID: <20190922184924.32534-75-sashal@kernel.org> (raw)
In-Reply-To: <20190922184924.32534-1-sashal@kernel.org>

From: Sakari Ailus <sakari.ailus@linux.intel.com>

[ Upstream commit 7ef57be07ac146e70535747797ef4aee0f06e9f9 ]

The streaming state should be set to the first upstream sub-device only,
not everywhere, for a sub-device driver itself knows how to best control
the streaming state of its own upstream sub-devices.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/media/platform/omap3isp/isp.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
index 38849f0ba09d3..8a87f427c056e 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -719,6 +719,10 @@ static int isp_pipeline_enable(struct isp_pipeline *pipe,
 					s_stream, mode);
 			pipe->do_propagation = true;
 		}
+
+		/* Stop at the first external sub-device. */
+		if (subdev->dev != isp->dev)
+			break;
 	}
 
 	return 0;
@@ -833,6 +837,10 @@ static int isp_pipeline_disable(struct isp_pipeline *pipe)
 						      &subdev->entity);
 			failure = -ETIMEDOUT;
 		}
+
+		/* Stop at the first external sub-device. */
+		if (subdev->dev != isp->dev)
+			break;
 	}
 
 	return failure;
-- 
2.20.1


  parent reply	other threads:[~2019-09-22 19:26 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190922184924.32534-1-sashal@kernel.org>
2019-09-22 18:46 ` [PATCH AUTOSEL 5.2 012/185] media: dib0700: fix link error for dibx000_i2c_set_speed Sasha Levin
2019-09-22 18:46 ` [PATCH AUTOSEL 5.2 013/185] media: mtk-cir: lower de-glitch counter for rc-mm protocol Sasha Levin
2019-09-22 18:46 ` [PATCH AUTOSEL 5.2 015/185] media: exynos4-is: fix leaked of_node references Sasha Levin
2019-09-22 18:46 ` [PATCH AUTOSEL 5.2 016/185] media: vivid:add sanity check to avoid divide error and set value to 1 if 0 Sasha Levin
2019-09-22 18:46 ` [PATCH AUTOSEL 5.2 017/185] media: vb2: reorder checks in vb2_poll() Sasha Levin
2019-09-22 18:46 ` [PATCH AUTOSEL 5.2 018/185] media: vivid: work around high stack usage with clang Sasha Levin
2019-09-22 18:46 ` [PATCH AUTOSEL 5.2 019/185] media: hdpvr: Add device num check and handling Sasha Levin
2019-09-22 18:46 ` [PATCH AUTOSEL 5.2 020/185] media: i2c: ov5640: Check for devm_gpiod_get_optional() error Sasha Levin
2019-09-22 18:46 ` [PATCH AUTOSEL 5.2 032/185] media: iguanair: add sanity checks Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 045/185] media: media/platform: fsl-viu.c: fix build for MICROBLAZE Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 058/185] media: gspca: zero usb_buf on error Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 061/185] media: mtk-mdp: fix reference count on old device tree Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 062/185] media: i2c: tda1997x: prevent potential NULL pointer access Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 063/185] media: fdp1: Reduce FCP not found message level to debug Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 064/185] media: em28xx: modules workqueue not inited for 2nd device Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 067/185] media: rc: imon: Allow iMON RC protocol for ffdc 7e device Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 073/185] media: vsp1: fix memory leak of dl on error return path Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 074/185] media: i2c: ov5645: Fix power sequence Sasha Levin
2019-09-22 18:47 ` Sasha Levin [this message]
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 076/185] media: imx: mipi csi-2: Don't fail if initial state times-out Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 084/185] media: radio/si470x: kill urb on error Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 085/185] media: hdpvr: add terminating 0 at end of string Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 097/185] media: mceusb: fix (eliminate) TX IR signal length limit Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 098/185] media: dvb-frontends: use ida for pll number Sasha Levin
2019-09-22 18:47 ` [PATCH AUTOSEL 5.2 100/185] media: dvb-core: fix a memory leak bug Sasha Levin
2019-09-22 18:48 ` [PATCH AUTOSEL 5.2 112/185] media: cec-notifier: clear cec_adap in cec_notifier_unregister Sasha Levin
2019-09-22 18:48 ` [PATCH AUTOSEL 5.2 113/185] media: saa7146: add cleanup in hexium_attach() Sasha Levin
2019-09-22 18:48 ` [PATCH AUTOSEL 5.2 114/185] media: cpia2_usb: fix memory leaks Sasha Levin
2019-09-22 18:48 ` [PATCH AUTOSEL 5.2 115/185] media: saa7134: fix terminology around saa7134_i2c_eeprom_md7134_gate() Sasha Levin
2019-09-22 18:48 ` [PATCH AUTOSEL 5.2 119/185] media: aspeed-video: address a protential usage of an unitialized var Sasha Levin
2019-09-22 18:48 ` [PATCH AUTOSEL 5.2 120/185] media: ov9650: add a sanity check Sasha Levin
2019-09-22 18:49 ` [PATCH AUTOSEL 5.2 170/185] media: technisat-usb2: break out of loop at end of buffer Sasha Levin
2019-09-22 18:49 ` [PATCH AUTOSEL 5.2 176/185] media: ttusb-dec: Fix info-leak in ttusb_dec_send_command() Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190922184924.32534-75-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).