From: Sean Young <sean@mess.org>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Benson Gui <Benson.Gui@synaptics.com>
Subject: Re: [PATCH] media: rc-map: Sort rc map name MACROs
Date: Tue, 1 Oct 2019 10:09:54 +0100 [thread overview]
Message-ID: <20191001090953.GA15901@gofer.mess.org> (raw)
In-Reply-To: <20190830152143.4ad42aeb@xhacker.debian>
Hello,
On Fri, Aug 30, 2019 at 07:33:08AM +0000, Jisheng Zhang wrote:
> Except RC_MAP_SU3000 and RC_MAP_HAUPPAUGE, others are alphabetically
> sorted. Sort names alphabetically.
>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> ---
> include/media/rc-map.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/media/rc-map.h b/include/media/rc-map.h
> index bebd3c4c6338..af71b08be9f2 100644
> --- a/include/media/rc-map.h
> +++ b/include/media/rc-map.h
> @@ -215,6 +215,7 @@ struct rc_map *rc_map_get(const char *name);
> #define RC_MAP_GENIUS_TVGO_A11MCE "rc-genius-tvgo-a11mce"
> #define RC_MAP_GOTVIEW7135 "rc-gotview7135"
> #define RC_MAP_HAUPPAUGE_NEW "rc-hauppauge"
> +#define RC_MAP_HAUPPAUGE "rc-hauppauge"
> #define RC_MAP_HISI_POPLAR "rc-hisi-poplar"
> #define RC_MAP_HISI_TV_DEMO "rc-hisi-tv-demo"
> #define RC_MAP_IMON_MCE "rc-imon-mce"
> @@ -253,13 +254,13 @@ struct rc_map *rc_map_get(const char *name);
> #define RC_MAP_PROTEUS_2309 "rc-proteus-2309"
> #define RC_MAP_PURPLETV "rc-purpletv"
> #define RC_MAP_PV951 "rc-pv951"
> -#define RC_MAP_HAUPPAUGE "rc-hauppauge"
> #define RC_MAP_RC5_TV "rc-rc5-tv"
> #define RC_MAP_RC6_MCE "rc-rc6-mce"
> #define RC_MAP_REAL_AUDIO_220_32_KEYS "rc-real-audio-220-32-keys"
> #define RC_MAP_REDDO "rc-reddo"
> #define RC_MAP_SNAPSTREAM_FIREFLY "rc-snapstream-firefly"
> #define RC_MAP_STREAMZAP "rc-streamzap"
> +#define RC_MAP_SU3000 "rc-su3000"
> #define RC_MAP_TANGO "rc-tango"
> #define RC_MAP_TBS_NEC "rc-tbs-nec"
> #define RC_MAP_TECHNISAT_TS35 "rc-technisat-ts35"
> @@ -282,7 +283,6 @@ struct rc_map *rc_map_get(const char *name);
> #define RC_MAP_VIDEOMATE_TV_PVR "rc-videomate-tv-pvr"
> #define RC_MAP_WINFAST "rc-winfast"
> #define RC_MAP_WINFAST_USBII_DELUXE "rc-winfast-usbii-deluxe"
> -#define RC_MAP_SU3000 "rc-su3000"
> #define RC_MAP_XBOX_DVD "rc-xbox-dvd"
> #define RC_MAP_ZX_IRDEC "rc-zx-irdec"
I'm afraid this doesn't make the list sorted. RC_MAP_X96MAX sorts before
RC_MAP_XBOX_DVD and RC_MAP_PIXELVIEW before RC_MAP_PIXELVIEW_NEW.
Thanks,
Sean
prev parent reply other threads:[~2019-10-01 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 7:33 [PATCH] media: rc-map: Sort rc map name MACROs Jisheng Zhang
2019-10-01 9:09 ` Sean Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001090953.GA15901@gofer.mess.org \
--to=sean@mess.org \
--cc=Benson.Gui@synaptics.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox