Re: [Patch 00/19] media: ti-vpe: cal: maintenance

Hans Verkuil
2019-10-21T10:50:12Z

Hi Benoit,

This series looks good to me. I had just one small comment on patch 7
and a comment on patch 19.

Just post a v2 for just patch 7/19 and post a patch 20/19 for the requested
MAINTAINERS change.

Once I have Rob's Acks I can merge this.

Regards,

Hans

On 10/18/19 5:34 PM, Benoit Parrot wrote:
> This a collection of backlog patches I have been carrying for the CAL
> driver.
>
> - Add support for SoC variants.
>
> - Switches to syscon/regmap to access a system controller register for
> the DPHY configuration. This register has different bit layout depending
> on the SoC version.
>
> - It adds supports for pre ES2.0 silicon errata.
>
> - Reworked the DPHY initialization sequence to match the technical
> reference manual and provide a more robust restartability.
>
> - Adds the missing ability to power subdevice.
>
> - Update the devicetree binding and then converts it to dt-schema
>
> Benoit Parrot (18):
> dt-bindings: media: cal: update binding to use syscon
> dt-bindings: media: cal: update binding example
> media: ti-vpe: cal: Add per platform data support
> media: ti-vpe: cal: Enable DMABUF export
> dt-bindings: media: cal: update binding to add PHY LDO errata support
> media: ti-vpe: cal: add CSI2 PHY LDO errata support
> media: ti-vpe: cal: Fix ths_term/ths_settle parameters
> media: ti-vpe: cal: Fix pixel processing parameters
> media: ti-vpe: cal: Align DPHY init sequence with docs
> dt-bindings: media: cal: update binding to add DRA76x support
> media: ti-vpe: cal: Add DRA76x support
> dt-bindings: media: cal: update binding to add AM654 support
> media: ti-vpe: cal: Add AM654 support
> media: ti-vpe: cal: Add subdev s_power hooks
> media: ti-vpe: cal: Properly calculate max resolution boundary
> media: ti-vpe: cal: Fix a WARN issued when start streaming fails
> media: ti-vpe: cal: fix enum_mbus_code/frame_size subdev arguments
> dt-bindings: media: cal: convert binding to yaml
>
> Nikhil Devshatwar (1):
> media: ti-vpe: cal: Restrict DMA to avoid memory corruption
>
> .../devicetree/bindings/media/ti,cal.yaml | 186 +++++
> .../devicetree/bindings/media/ti-cal.txt | 72 --
> drivers/media/platform/Kconfig | 2 +-
> drivers/media/platform/ti-vpe/cal.c | 775 ++++++++++++++----
> drivers/media/platform/ti-vpe/cal_regs.h | 27 +
> 5 files changed, 830 insertions(+), 232 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/ti,cal.yaml
> delete mode 100644 Documentation/devicetree/bindings/media/ti-cal.txt
>