Re: [Patch 02/19] dt-bindings: media: cal: update binding example

Benoit Parrot
2019-10-30T13:41:25Z

Rob Herring <robh@kernel.org> wrote on Tue [2019-Oct-29 08:21:57 -0500]:
> On Fri, Oct 18, 2019 at 10:34:20AM -0500, Benoit Parrot wrote:
> > Update binding example to show proper endpoint properties and linkage.
> >
> > Signed-off-by: Benoit Parrot <bparrot@ti.com>
> > ---
> > .../devicetree/bindings/media/ti-cal.txt | 32 ++++++++++---------
> > 1 file changed, 17 insertions(+), 15 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/ti-cal.txt b/Documentation/devicetree/bindings/media/ti-cal.txt
> > index 782f801b12a9..6b56fddcfc4a 100644
> > --- a/Documentation/devicetree/bindings/media/ti-cal.txt
> > +++ b/Documentation/devicetree/bindings/media/ti-cal.txt
> > @@ -27,7 +27,6 @@ Documentation/devicetree/bindings/media/video-interfaces.txt.
> > Example:
> > cal: cal@4845b000 {
> > compatible = "ti,dra72-cal";
> > - ti,hwmods = "cal";
> > reg = <0x4845B000 0x400>,
> > <0x4845B800 0x40>,
> > <0x4845B900 0x40>;
> > @@ -45,9 +44,10 @@ Example:
> >
> > csi2_0: port@0 {
> > reg = <0>;
> > - endpoint {
> > - slave-mode;
> > - remote-endpoint = <&ar0330_1>;
> > + csi2_phy0: endpoint@0 {
>
> Unit address without 'reg' is not correct.

Ok so just "endpoint" then?

>
> > + remote-endpoint = <&csi2_cam0>;
> > + clock-lanes = <0>;
> > + data-lanes = <1 2>;
> > };
> > };
> > csi2_1: port@1 {
> > @@ -57,19 +57,21 @@ Example:
> > };
> >
> > i2c5: i2c@4807c000 {
> > - ar0330@10 {
> > - compatible = "ti,ar0330";
> > - reg = <0x10>;
> > + status = "okay";
>
> Don't show status in examples.

Ok.

>
> > + clock-frequency = <400000>;
> >
> > - port {
> > - #address-cells = <1>;
> > - #size-cells = <0>;
> > + ov5640@3c {
>
> camera-sensor@3c

Ok.

>
> > + compatible = "ovti,ov5640";
> > + reg = <0x3c>;
> > +
> > + clocks = <&clk_ov5640_fixed>;
> > + clock-names = "xclk";
> >
> > - ar0330_1: endpoint {
> > - reg = <0>;
> > - clock-lanes = <1>;
> > - data-lanes = <0 2 3 4>;
> > - remote-endpoint = <&csi2_0>;
> > + port {
> > + csi2_cam0: endpoint {
> > + remote-endpoint = <&csi2_phy0>;
> > + clock-lanes = <0>;
> > + data-lanes = <1 2>;
> > };
> > };
> > };
> > --
> > 2.17.1
> >