Linux Media Controller development
 help / color / mirror / Atom feed
From: Ricardo Ribalda Delgado <ribalda@kernel.org>
To: hverkuil-cisco@xs4all.nl, sakari.ailus@linux.intel.com,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ribalda@kernel.org>
Subject: [PATCH] Documentation: media: *_DEFAULT targets for subdevs
Date: Thu, 24 Oct 2019 10:40:14 +0200	[thread overview]
Message-ID: <20191024084014.22424-1-ribalda@kernel.org> (raw)

Some sensors have optical blanking areas, this is, pixels that are
painted and do not account for light, only noise.

These special pixels are very useful for calibrating the sensor, but
should not be displayed on a DEFAULT target.

Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
---
 .../media/uapi/v4l/v4l2-selection-targets.rst | 24 ++++---------------
 1 file changed, 5 insertions(+), 19 deletions(-)

diff --git a/Documentation/media/uapi/v4l/v4l2-selection-targets.rst b/Documentation/media/uapi/v4l/v4l2-selection-targets.rst
index f74f239b0510..4b356f66525e 100644
--- a/Documentation/media/uapi/v4l/v4l2-selection-targets.rst
+++ b/Documentation/media/uapi/v4l/v4l2-selection-targets.rst
@@ -19,7 +19,7 @@ of the two interfaces they are used.
 
 .. _v4l2-selection-targets-table:
 
-.. tabularcolumns:: |p{6.0cm}|p{1.4cm}|p{7.4cm}|p{1.2cm}|p{1.4cm}|
+.. tabularcolumns:: |p{6.0cm}|p{1.4cm}|p{10.0cm}|
 
 .. flat-table:: Selection target definitions
     :header-rows:  1
@@ -28,49 +28,35 @@ of the two interfaces they are used.
     * - Target name
       - id
       - Definition
-      - Valid for V4L2
-      - Valid for V4L2 subdev
     * - ``V4L2_SEL_TGT_CROP``
       - 0x0000
       - Crop rectangle. Defines the cropped area.
-      - Yes
-      - Yes
     * - ``V4L2_SEL_TGT_CROP_DEFAULT``
       - 0x0001
       - Suggested cropping rectangle that covers the "whole picture".
-      - Yes
-      - No
+        This includes only active pixels and excludes other non-active
+        pixels such as Optical Blanking.
     * - ``V4L2_SEL_TGT_CROP_BOUNDS``
       - 0x0002
       - Bounds of the crop rectangle. All valid crop rectangles fit inside
 	the crop bounds rectangle.
-      - Yes
-      - Yes
     * - ``V4L2_SEL_TGT_NATIVE_SIZE``
       - 0x0003
       - The native size of the device, e.g. a sensor's pixel array.
 	``left`` and ``top`` fields are zero for this target.
-      - Yes
-      - Yes
     * - ``V4L2_SEL_TGT_COMPOSE``
       - 0x0100
       - Compose rectangle. Used to configure scaling and composition.
-      - Yes
-      - Yes
     * - ``V4L2_SEL_TGT_COMPOSE_DEFAULT``
       - 0x0101
       - Suggested composition rectangle that covers the "whole picture".
-      - Yes
-      - No
+        This includes only active pixels and excludes other non-active
+        pixels such as Optical Blanking.
     * - ``V4L2_SEL_TGT_COMPOSE_BOUNDS``
       - 0x0102
       - Bounds of the compose rectangle. All valid compose rectangles fit
 	inside the compose bounds rectangle.
-      - Yes
-      - Yes
     * - ``V4L2_SEL_TGT_COMPOSE_PADDED``
       - 0x0103
       - The active area and all padding pixels that are inserted or
 	modified by hardware.
-      - Yes
-      - No
-- 
2.23.0


             reply	other threads:[~2019-10-24  8:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  8:40 Ricardo Ribalda Delgado [this message]
2019-10-24 10:19 ` [PATCH] Documentation: media: *_DEFAULT targets for subdevs Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024084014.22424-1-ribalda@kernel.org \
    --to=ribalda@kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox