From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Ricardo Ribalda Delgado <ribalda@kernel.org>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Documentation: media: *_DEFAULT targets for subdevs
Date: Thu, 24 Oct 2019 17:04:29 +0300 [thread overview]
Message-ID: <20191024140428.GF3966@mara.localdomain> (raw)
In-Reply-To: <CAPybu_2hdvq_M-8X0_-MVxSjaJ8H0x+zDRaa4Cf=b0PQtVnzmQ@mail.gmail.com>
Hi Ricardo,
On Thu, Oct 24, 2019 at 03:43:36PM +0200, Ricardo Ribalda Delgado wrote:
> Hi Sakari
>
> Lets say the user wants to select the active pixels. He needs to set
> the crop and the compose.
>
> 1) he gets V4L2_SEL_TGT_CROP_DEFAULT
>
> 2) he sets V4L2_SEL_TGT_CROP
>
> How does he knows which compose to use? What if the compose starts at
> (0,0) instead of (32,32)....?
>
> I think it is easier if
>
> 3) he gets V4L2_SEL_TGT_COMPOSE_DEFAULT
>
> 4) he sets V4L2_SEL_TGT_COMPOSE
>
> This is similar as how we do it today with a v4l2_device. What if we
> simply replicate that behaviour?
The compose rectangle is relative to the crop rectangle (if there's a crop
rectangle), and always starts at 0,0.
See:
<URL:https://hverkuil.home.xs4all.nl/spec/uapi/v4l/dev-subdev.html#selections-cropping-scaling-and-composition>
--
Sakari Ailus
sakari.ailus@linux.intel.com
prev parent reply other threads:[~2019-10-24 14:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 12:35 [PATCH v2] Documentation: media: *_DEFAULT targets for subdevs Ricardo Ribalda Delgado
2019-10-24 12:35 ` [PATCH v2] v4l2-compliance: Allow all the selection " Ricardo Ribalda Delgado
2019-10-24 13:33 ` [PATCH v2] Documentation: media: *_DEFAULT " Sakari Ailus
2019-10-24 13:43 ` Ricardo Ribalda Delgado
2019-10-24 14:04 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024140428.GF3966@mara.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=ribalda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox