From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-media@vger.kernel.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] media: i2c: IMX296 camera sensor driver
Date: Tue, 5 Nov 2019 22:38:00 +0200 [thread overview]
Message-ID: <20191105203800.GF4869@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20191105172414.GA14607@kekkonen.localdomain>
On Tue, Nov 05, 2019 at 07:24:15PM +0200, Sakari Ailus wrote:
> On Tue, Nov 05, 2019 at 08:33:55PM +0530, Manivannan Sadhasivam wrote:
> ...
> > > > > +static int imx296_remove(struct i2c_client *client)
> > > > > +{
> > > > > + struct v4l2_subdev *subdev = i2c_get_clientdata(client);
> > > > > + struct imx296 *imx = to_imx296(subdev);
> > > > > +
> > > > > + v4l2_async_unregister_subdev(subdev);
> > > > > + media_entity_cleanup(&subdev->entity);
> > > > > + v4l2_ctrl_handler_free(&imx->ctrls);
> > > > > +
> > > > > + return 0;
> > > > > +}
> > > > > +
> > > > > +#if IS_ENABLED(CONFIG_OF)
> >
> > I think you don't need this guard if of_match_ptr is used.
>
> There's also need for of_match_ptr, it should be removed.
I'll fix both.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-11-05 20:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 13:23 [PATCH] media: i2c: IMX296 camera sensor driver Laurent Pinchart
2019-10-31 14:25 ` Sakari Ailus
2019-11-04 13:33 ` Laurent Pinchart
2019-11-04 15:20 ` Sakari Ailus
2019-11-04 18:59 ` Laurent Pinchart
2019-11-04 21:30 ` Sakari Ailus
2019-11-05 20:36 ` Laurent Pinchart
2019-11-05 20:59 ` Sakari Ailus
2019-11-01 14:52 ` Manivannan Sadhasivam
2019-11-01 17:37 ` Sakari Ailus
2019-11-04 13:42 ` Laurent Pinchart
2019-11-04 21:08 ` Rob Herring
2019-11-04 22:03 ` Laurent Pinchart
2019-11-04 22:15 ` Rob Herring
2019-11-05 15:03 ` Manivannan Sadhasivam
2019-11-05 17:24 ` Sakari Ailus
2019-11-05 20:38 ` Laurent Pinchart [this message]
2019-11-05 20:41 ` Laurent Pinchart
2020-11-26 15:59 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105203800.GF4869@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox