From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B2BBC341B7 for ; Fri, 13 Dec 2019 20:38:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9516A24705 for ; Fri, 13 Dec 2019 20:38:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lP57kF26" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727762AbfLMPXo (ORCPT ); Fri, 13 Dec 2019 10:23:44 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:55416 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727536AbfLMPXo (ORCPT ); Fri, 13 Dec 2019 10:23:44 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 02C04E41; Fri, 13 Dec 2019 16:23:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1576250622; bh=9YNy9xTU5XimeURCP7Sp1qumv4WSHztJ66YuDPP2q/M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lP57kF262X0/Yg4V8og2glamOK5n6U+VScNg78VEBGo7DcBAmygHqGH8IFR720RiQ GuVYu1QoCorwQP3984jpVDTfsdzttoem/n3xSoLfNXXnvvgdWlwmQjeWA7Xv7q2Fpw PPZ6vsIVlhxpqgDBg8v/fViFeBorsDzRjx7UyCmI= Date: Fri, 13 Dec 2019 17:23:32 +0200 From: Laurent Pinchart To: Boris Brezillon Cc: Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , linux-media@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Tomasz Figa , Nicolas Dufresne , kernel@collabora.com, Paul Kocialkowski , Ezequiel Garcia , Jonas Karlman , linux-rockchip@lists.infradead.org, Heiko Stuebner Subject: Re: [PATCH v3 5/7] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings Message-ID: <20191213152332.GF4860@pendragon.ideasonboard.com> References: <20191213125414.90725-1-boris.brezillon@collabora.com> <20191213125414.90725-6-boris.brezillon@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191213125414.90725-6-boris.brezillon@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Boris, Thank you for the patch. On Fri, Dec 13, 2019 at 01:54:12PM +0100, Boris Brezillon wrote: > Document the Rockchip RK3399 Video Decoder bindings. > > Signed-off-by: Boris Brezillon > --- > Changes in v3: > * Fix dtbs_check failures > --- > .../bindings/media/rockchip,vdec.yaml | 71 +++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > new file mode 100644 > index 000000000000..7167c3d6a389 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/rockchip,vdec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip Video Decoder (VDec) Device Tree Bindings > + > +maintainers: > + - Heiko Stuebner > + > +description: |- > + The Rockchip rk3399 has a stateless Video Decoder that can decodes H.264, > + HEVC an VP9 streams. > + > +properties: > + compatible: > + const: rockchip,rk3399-vdec > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: The Video Decoder AXI interface clock > + - description: The Video Decoder AHB interface clock > + - description: The Video Decoded CABAC clock > + - description: The Video Decoder core clock > + > + clock-names: > + items: > + - const: aclk How about calling it "axi" ? None of the other clock names have "clk". > + - const: iface And "ahb" here, as the AXI interface clock is also an interface clock ? > + - const: cabac > + - const: core > + > + power-domains: > + maxItems: 1 > + > + iommus: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + vdec: video-codec@ff660000 { > + compatible = "rockchip,rk3399-vdec"; > + reg = <0x0 0xff660000 0x0 0x400>; > + interrupts = ; > + clocks = <&cru ACLK_VDU>, <&cru HCLK_VDU>, > + <&cru SCLK_VDU_CA>, <&cru SCLK_VDU_CORE>; > + clock-names = "aclk", "iface", "cabac", "core"; > + power-domains = <&power RK3399_PD_VDU>; > + iommus = <&vdec_mmu>; > + }; > + > +... -- Regards, Laurent Pinchart