From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896D7C43603 for ; Mon, 16 Dec 2019 22:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BB342176D for ; Mon, 16 Dec 2019 22:57:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726756AbfLPW5u (ORCPT ); Mon, 16 Dec 2019 17:57:50 -0500 Received: from iodev.co.uk ([193.29.56.124]:39926 "EHLO iodev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726700AbfLPW5t (ORCPT ); Mon, 16 Dec 2019 17:57:49 -0500 X-Greylist: delayed 459 seconds by postgrey-1.27 at vger.kernel.org; Mon, 16 Dec 2019 17:57:49 EST Date: Tue, 17 Dec 2019 00:42:04 +0100 From: Ismael Luceno To: Takashi Iwai Cc: linux-media@vger.kernel.org, alsa-devel@alsa-project.org, Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Mauro Carvalho Chehab Subject: Re: [PATCH for-5.6 01/14] media: solo6x10: Use managed buffer allocation Message-ID: <20191216234204.GA32004@pirotess.home> References: <20191210135849.15607-1-tiwai@suse.de> <20191210135849.15607-2-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191210135849.15607-2-tiwai@suse.de> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 10/Dec/2019 14:58, Takashi Iwai wrote: > Clean up the driver with the new managed buffer allocation API. > The hw_params and hw_free callbacks became superfluous and dropped. > > Cc: Bluecherry Maintainers > Cc: Anton Sviridenko > Cc: Andrey Utkin > Cc: Ismael Luceno > Cc: Mauro Carvalho Chehab > Signed-off-by: Takashi Iwai > --- > drivers/media/pci/solo6x10/solo6x10-g723.c | 23 +++++------------------ > 1 file changed, 5 insertions(+), 18 deletions(-) > > diff --git a/drivers/media/pci/solo6x10/solo6x10-g723.c b/drivers/media/pci/solo6x10/solo6x10-g723.c > index eaa57d835ea8..ca349d447610 100644 > --- a/drivers/media/pci/solo6x10/solo6x10-g723.c > +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c > @@ -97,17 +97,6 @@ void solo_g723_isr(struct solo_dev *solo_dev) > } > } > > -static int snd_solo_hw_params(struct snd_pcm_substream *ss, > - struct snd_pcm_hw_params *hw_params) > -{ > - return snd_pcm_lib_malloc_pages(ss, params_buffer_bytes(hw_params)); > -} > - > -static int snd_solo_hw_free(struct snd_pcm_substream *ss) > -{ > - return snd_pcm_lib_free_pages(ss); > -} > - > static const struct snd_pcm_hardware snd_solo_pcm_hw = { > .info = (SNDRV_PCM_INFO_MMAP | > SNDRV_PCM_INFO_INTERLEAVED | > @@ -271,8 +260,6 @@ static const struct snd_pcm_ops snd_solo_pcm_ops = { > .open = snd_solo_pcm_open, > .close = snd_solo_pcm_close, > .ioctl = snd_pcm_lib_ioctl, > - .hw_params = snd_solo_hw_params, > - .hw_free = snd_solo_hw_free, > .prepare = snd_solo_pcm_prepare, > .trigger = snd_solo_pcm_trigger, > .pointer = snd_solo_pcm_pointer, > @@ -351,11 +338,11 @@ static int solo_snd_pcm_init(struct solo_dev *solo_dev) > ss; ss = ss->next, i++) > sprintf(ss->name, "Camera #%d Audio", i); > > - snd_pcm_lib_preallocate_pages_for_all(pcm, > - SNDRV_DMA_TYPE_CONTINUOUS, > - NULL, > - G723_PERIOD_BYTES * PERIODS, > - G723_PERIOD_BYTES * PERIODS); > + snd_pcm_set_managed_buffer_all(pcm, > + SNDRV_DMA_TYPE_CONTINUOUS, > + NULL, > + G723_PERIOD_BYTES * PERIODS, > + G723_PERIOD_BYTES * PERIODS); > > solo_dev->snd_pcm = pcm; > > -- > 2.16.4 > Signed-off-by: Ismael Luceno