Re: [PATCH] serial_ir: change "ignoring spike" to debug level

[Sean Young <sean@mess.org>]

Hi,

On Wed, Dec 25, 2019 at 07:02:56PM +0100, Bodo Eggert wrote:
> At least on my system with a self-made IR receiver, my kernel log is filled with:
> serial_ir serial_ir.0: ignoring spike: 1 1 1419988034627194ns 1419956080709377ns
> 
> These messages happen at random and do not prevent the receiver from
> working. Also I cannot change the features of the IC, therefore they are not
> useful. Probably they are not useful at all.
> 
> However they fill the console, they accumulate and fill the dmesg log, by
> doing this, they prevent me from seeing important message.

I think this patch is right, but it needs a Signed-off-by: line.

See:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Thanks,

Sean

> ---
>  drivers/media/rc/serial_ir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/rc/serial_ir.c b/drivers/media/rc/serial_ir.c
> index 7652e982173f..d77507ba0fb5 100644
> --- a/drivers/media/rc/serial_ir.c
> +++ b/drivers/media/rc/serial_ir.c
> @@ -353,7 +353,7 @@ static irqreturn_t serial_ir_irq_handler(int i, void *blah)
>  			dcd = (status & hardware[type].signal_pin) ? 1 : 0;
>  
>  			if (dcd == last_dcd) {
> -				dev_err(&serial_ir.pdev->dev,
> +				dev_dbg(&serial_ir.pdev->dev,
>  					"ignoring spike: %d %d %lldns %lldns\n",
>  					dcd, sense, ktime_to_ns(kt),
>  					ktime_to_ns(serial_ir.lastkt));
> -- 
> 2.24.0