From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28A35C282DD for ; Wed, 8 Jan 2020 15:18:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE37720692 for ; Wed, 8 Jan 2020 15:18:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="UiFkogC2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727684AbgAHPS3 (ORCPT ); Wed, 8 Jan 2020 10:18:29 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:34036 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726556AbgAHPS2 (ORCPT ); Wed, 8 Jan 2020 10:18:28 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 008FAM58175026; Wed, 8 Jan 2020 15:18:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=JWAazoicBsj1dkTDy4BLFaF4LrMkkoJBdvLPtIWlQow=; b=UiFkogC2O0VmEayMzQLMJuo0HPlw1Rg1L7p+R4Nwrtd/VG/4P5M1UqRn+kyKREWe/wat AHYQYe+CNpcuJNaij88WPViMk+SFOZinEoDDJ9YXvusWuSZPW2tfQrwvwf03yKrm7hA7 bsp5f41vHt+Ltmv0fuk40n/s/NiAkPEbkT0pLOe7TrFVW8AEfGP8hEx/L5aGtZFLOWDr vjUyVA2vYbw4NQUqlUR/yODY9uYWGlPZLvdPlRgFTk1w7W9Kp2UqlkA5F90j5RuRzwGa 5GFOYCPrxx8+9+nHo9JJqBumPcbQX6RBC+PsL6ty0WmuOyouyPCWDfB4Y+plHukI+ekV Xg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2xaj4u4mje-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 08 Jan 2020 15:18:21 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 008FAR4v053481; Wed, 8 Jan 2020 15:18:21 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2xcjvft1s0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 08 Jan 2020 15:18:21 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 008FIH7m026416; Wed, 8 Jan 2020 15:18:19 GMT Received: from kadam (/10.175.168.130) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 08 Jan 2020 07:18:17 -0800 Date: Wed, 8 Jan 2020 18:18:09 +0300 From: Dan Carpenter To: Ezequiel Garcia Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] media: hantro: remove a pointless NULL check Message-ID: <20200108151809.GG27042@kadam> References: <20200108053534.6rwxk2httwoflbgv@kili.mountain> <1118f946572b3da0562fa1c0347fceaeda93f38f.camel@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1118f946572b3da0562fa1c0347fceaeda93f38f.camel@collabora.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9493 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001080128 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9493 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001080128 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, Jan 08, 2020 at 12:08:21PM -0300, Ezequiel Garcia wrote: > Hi Dan, > > Thanks for the patch. > > On Wed, 2020-01-08 at 08:35 +0300, Dan Carpenter wrote: > > This can't be NULL and we've already dereferenced it so let's remove > > the check. > > > > Signed-off-by: Dan Carpenter > > --- > > drivers/staging/media/hantro/hantro_v4l2.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/media/hantro/hantro_v4l2.c b/drivers/staging/media/hantro/hantro_v4l2.c > > index 85af1b96fd34..0198bcda26b7 100644 > > --- a/drivers/staging/media/hantro/hantro_v4l2.c > > +++ b/drivers/staging/media/hantro/hantro_v4l2.c > > @@ -688,7 +688,7 @@ static int hantro_start_streaming(struct vb2_queue *q, unsigned int count) > > return ret; > > > > err_codec_exit: > > - if (ctx->codec_ops && ctx->codec_ops->exit) > > + if (ctx->codec_ops->exit) > > Since you are here, can you remove the other unneeded > checks in the driver? > There is only one more, but yes, I should remove it as well. > We are assuming ctx->codec_op is non-NULL, so perhaps > a check in .probe, to check it explicitly would be better. It's the address from inside the middle of a struct so it can't possibly be NULL. No need to check. regards, dan carpenter