From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5669C33CA9 for ; Mon, 13 Jan 2020 17:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFCEC2075B for ; Mon, 13 Jan 2020 17:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726985AbgAMRxM (ORCPT ); Mon, 13 Jan 2020 12:53:12 -0500 Received: from mga05.intel.com ([192.55.52.43]:30135 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726435AbgAMRxL (ORCPT ); Mon, 13 Jan 2020 12:53:11 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 09:53:10 -0800 X-IronPort-AV: E=Sophos;i="5.69,429,1571727600"; d="scan'208";a="217475489" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 09:53:09 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 11E7520AF3; Mon, 13 Jan 2020 19:53:07 +0200 (EET) Date: Mon, 13 Jan 2020 19:53:07 +0200 From: Sakari Ailus To: Bingbu Cao Cc: Tomasz Figa , Bingbu Cao , Linux Media Mailing List , "Qiu, Tian Shu" Subject: Re: [PATCH v2] media: staging/intel-ipu3: make imgu use fixed running mode Message-ID: <20200113175306.GG5440@paasikivi.fi.intel.com> References: <1577697985-10920-1-git-send-email-bingbu.cao@intel.com> <51c16983-a2e5-d18d-1852-bed88e9ca8b8@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Bingbu, On Thu, Jan 09, 2020 at 12:37:07PM +0800, Bingbu Cao wrote: > > > On 1/9/20 12:06 PM, Tomasz Figa wrote: > > On Thu, Jan 9, 2020 at 12:58 PM Bingbu Cao wrote: > >> > >> > >> > >> On 1/8/20 8:57 PM, Tomasz Figa wrote: > >>> On Mon, Dec 30, 2019 at 6:21 PM Bingbu Cao wrote: > >>>> > >>>> Currently, the imgu running mode need user to set by v4l2 ctrl. > >>>> However, imgu only support 2 pipes and 2 operation modes - video and > >>>> still. This patch make the first imgu subdev running as video and second > >>>> one running as still, it will make the user understand easily, it can > >>>> also cover current camera use cases requirement. The running mode is set > >>>> during subdev registering, no race-condition after change, so it is safe > >>>> to change the mode data type to integer. > >>>> > >>>> Signed-off-by: Bingbu Cao > >>>> --- > >>>> Documentation/media/v4l-drivers/ipu3.rst | 6 +- > >>>> drivers/staging/media/ipu3/include/intel-ipu3.h | 4 -- > >>>> drivers/staging/media/ipu3/ipu3-v4l2.c | 74 +++---------------------- > >>>> drivers/staging/media/ipu3/ipu3.h | 5 +- > >>>> 4 files changed, 12 insertions(+), 77 deletions(-) > >>>> > >>> > >>> Doesn't it make it impossible to use two video (aka fast) pipes? > >> Hi, Tomasz, > >> Yes, once applying this patch, you can not run two video pipes with same input. > >> I have no idea what are fast pipes and which scenario need two video pipes if > >> the driver did not support multiple camera? > > > > Processing in video pipes is faster than in still pipes and so one > > could still want to use two video pipes for lower system load and thus > > also lower power consumption, even for a single camera scenario, but > > with ZSL. > > > > That said, AFAICT CIO2 wouldn't have problems handling 2 raw captures, > > so why would we want to prevent anyone from having 2 video pipes for 2 > > different cameras? > Tomasz, your comments make sense for me. we can not limit the usage. > > Sakari, > Do you have comments on that? Could we revert this patch? Please send a revert if you feel like it. -- Regards, Sakari Ailus