From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCDBFC2D0CE for ; Tue, 21 Jan 2020 22:53:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B30B12465B for ; Tue, 21 Jan 2020 22:53:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nq4aFWpu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbgAUWxY (ORCPT ); Tue, 21 Jan 2020 17:53:24 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:33276 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbgAUWxY (ORCPT ); Tue, 21 Jan 2020 17:53:24 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C1C9052A; Tue, 21 Jan 2020 23:53:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1579647201; bh=+o9lAebGcfIPvu6BwlMSFfOT4pdXPhZxgEAsy4SNm2E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nq4aFWpuAjtBfYJ8ciGIrsSYLe2oU+g5nTBkSi/7WHs22iD/iSDNauv5gn19he62S qUPdeLcyTH/uZojPqjxZV4KNVbGBMwNbZR0HdjB1ciQLxMs/lcjLxBj+hh2Ydq9pT3 p9wFPeq8MIE1hZVJlaSX4Ez83OSqRgw1rjRGVeSI= Date: Wed, 22 Jan 2020 00:53:05 +0200 From: Laurent Pinchart To: Will Deacon Cc: Andrey Konovalov , Greg Kroah-Hartman , linux-media@vger.kernel.org, LKML , Andrew Morton , Mauro Carvalho Chehab , Dmitry Vyukov , Kostya Serebryany , stable Subject: Re: [PATCH RESEND RESEND] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors Message-ID: <20200121225305.GL5003@pendragon.ideasonboard.com> References: <20191108154838.21487-1-will@kernel.org> <20191108155503.GB15731@pendragon.ideasonboard.com> <20191216121651.GA12947@willie-the-truck> <20191218114137.GA15505@willie-the-truck> <20191218122324.GB17086@kroah.com> <20191218165153.GC17876@pendragon.ideasonboard.com> <20200121190142.GB13592@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200121190142.GB13592@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Will, On Tue, Jan 21, 2020 at 07:01:42PM +0000, Will Deacon wrote: > On Wed, Dec 18, 2019 at 06:51:53PM +0200, Laurent Pinchart wrote: > > On Wed, Dec 18, 2019 at 01:46:00PM +0100, Andrey Konovalov wrote: > > > On Wed, Dec 18, 2019 at 1:23 PM Greg Kroah-Hartman wrote: > > > > On Wed, Dec 18, 2019 at 11:41:38AM +0000, Will Deacon wrote: > > > >> On Mon, Dec 16, 2019 at 02:17:52PM +0100, Andrey Konovalov wrote: > > > >>> On Mon, Dec 16, 2019 at 1:16 PM Will Deacon wrote: > > > >>>> On Fri, Nov 08, 2019 at 05:55:03PM +0200, Laurent Pinchart wrote: > > > >>>>> Thank you for the patch. > > > >>>>> > > > >>>>> I'm sorry for the delay, and will have to ask you to be a bit more > > > >>>>> patient I'm afraid. I will leave tomorrow for a week without computer > > > >>>>> access and will only be able to go through my backlog when I will be > > > >>>>> back on the 17th. > > > >>>> > > > >>>> Gentle reminder on this, now you've been back a month ;) > > > >>> > > > >>> I think we now have a reproducer for this issue that syzbot just reported: > > > >>> > > > >>> https://syzkaller.appspot.com/bug?extid=0a5c96772a9b26f2a876 > > > >>> > > > >>> You can try you patch on it :) > > > >> > > > >> Oh wow, I *really* like the raw USB gadget thingy you have to reproduce > > > >> these! I also really like that this patch fixes the issue. Logs below. > > > > > > Thanks! An easier way to test the patch would be to issue a syz test > > > command, but I'm glad you managed to set up raw gadget manually and it > > > worked for you. > > > > > > > > > > > Ok, that's a good poke for me to go review that raw gadget code to see > > > > if it can be merged upstream :) > > > > > > Looking forward to it! =) > > > > Reviewed-by: Laurent Pinchart > > > > and merged in my tree. I'm so sorry for the way too long delay. > > Please can you send this upstream and/or put it in linux-next? I can't see > it anywhere at the moment :( I've now sent the pull request. Seems I failed the schedule from A to Z with this patch. I'm extremely sorry :-( -- Regards, Laurent Pinchart