Re: [v2 2/3] media: ov8856: Add devicetree support

Fabio Estevam
2020-03-31T13:42:49Z

Hi Robert,

On Tue, Mar 31, 2020 at 10:37 AM Robert Foss <robert.foss@linaro.org> wrote:

> After testing this change, it breaks the driver during probing.

Why exactly does it break probing? Maybe the GPIO polarity defined in
the device tree is wrong?

> I had a quick look into GPIOD_OUT_HIGH & LOW definitions, and they
> seem to never be 0 or 1.

If you do a grep in all gpiod_set_value_cansleep() usages in the
kernel tree, there is not a single case where GPIOD_OUT_HIGH or
GPIOD_OUT_LOW is passed as argument of gpiod_set_value_cansleep().