From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-media@vger.kernel.org, Benoit Parrot <bparrot@ti.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH 07/16] media: ti-vpe: cal: remove unused defines
Date: Mon, 16 Mar 2020 14:31:29 +0200 [thread overview]
Message-ID: <20200316123129.GZ4732@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200313114121.32182-7-tomi.valkeinen@ti.com>
Hi Tomi,
Thank you for the patch.
On Fri, Mar 13, 2020 at 01:41:12PM +0200, Tomi Valkeinen wrote:
> Remove a bunch of IRQ defines that are never used.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/ti-vpe/cal_regs.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/media/platform/ti-vpe/cal_regs.h b/drivers/media/platform/ti-vpe/cal_regs.h
> index 532d4a95740a..b27c0445b8d5 100644
> --- a/drivers/media/platform/ti-vpe/cal_regs.h
> +++ b/drivers/media/platform/ti-vpe/cal_regs.h
> @@ -142,12 +142,6 @@
> #define CAL_HL_IRQ_EOI_LINE_NUMBER_EOI0 0
>
> #define CAL_HL_IRQ_MASK(m) BIT((m) - 1)
> -#define CAL_HL_IRQ_NOACTION 0x0
> -#define CAL_HL_IRQ_ENABLE 0x1
> -#define CAL_HL_IRQ_CLEAR 0x1
> -#define CAL_HL_IRQ_DISABLED 0x0
> -#define CAL_HL_IRQ_ENABLED 0x1
> -#define CAL_HL_IRQ_PENDING 0x1
>
> #define CAL_HL_IRQ_CIO_MASK(i) BIT(16 + (i-1) * 8)
> #define CAL_HL_IRQ_VC_MASK(i) BIT(17 + (i-1) * 8)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-03-16 12:31 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 11:41 [PATCH 01/16] media: ti-vpe: cal: fix use of wrong macro Tomi Valkeinen
2020-03-13 11:41 ` [PATCH 02/16] media: ti-vpe: cal: use runtime_resume for errata handling Tomi Valkeinen
2020-03-16 12:28 ` Laurent Pinchart
2020-03-17 8:54 ` Tomi Valkeinen
2020-03-13 11:41 ` [PATCH 03/16] media: ti-vpe: cal: catch error irqs and print errors Tomi Valkeinen
2020-03-16 10:06 ` Hans Verkuil
2020-03-16 10:51 ` Hans Verkuil
2020-03-16 12:00 ` Tomi Valkeinen
2020-03-16 12:16 ` Hans Verkuil
2020-03-16 12:22 ` Laurent Pinchart
2020-03-17 8:56 ` Tomi Valkeinen
2020-03-13 11:41 ` [PATCH 04/16] media: ti-vpe: cal: print errors on timeouts Tomi Valkeinen
2020-03-13 11:41 ` [PATCH 05/16] media: ti-vpe: cal: simplify irq handling Tomi Valkeinen
2020-03-13 11:41 ` [PATCH 06/16] media: ti-vpe: cal: remove useless CAL_GEN_* macros Tomi Valkeinen
2020-03-16 12:24 ` Laurent Pinchart
2020-03-13 11:41 ` [PATCH 07/16] media: ti-vpe: cal: remove unused defines Tomi Valkeinen
2020-03-16 12:31 ` Laurent Pinchart [this message]
2020-03-13 11:41 ` [PATCH 08/16] media: ti-vpe: cal: use reg_write_field Tomi Valkeinen
2020-03-16 12:32 ` Laurent Pinchart
2020-03-13 11:41 ` [PATCH 09/16] media: ti-vpe: cal: cleanup CIO power enable/disable Tomi Valkeinen
2020-03-16 12:35 ` Laurent Pinchart
2020-03-13 11:41 ` [PATCH 10/16] media: ti-vpe: cal: fix dummy read to phy Tomi Valkeinen
2020-03-16 12:36 ` Laurent Pinchart
2020-03-13 11:41 ` [PATCH 11/16] media: ti-vpe: cal: program number of lines properly Tomi Valkeinen
2020-03-16 12:37 ` Laurent Pinchart
2020-03-16 13:13 ` Tomi Valkeinen
2020-03-13 11:41 ` [PATCH 12/16] media: ti-vpe: cal: set DMA max seg size Tomi Valkeinen
2020-03-16 12:39 ` Laurent Pinchart
2020-03-13 11:41 ` [PATCH 13/16] media: ti-vpe: cal: move code to separate functions Tomi Valkeinen
2020-03-16 12:41 ` Laurent Pinchart
2020-03-17 9:04 ` Tomi Valkeinen
2020-03-13 11:41 ` [PATCH 14/16] media: ti-vpe: cal: improve wait for CIO resetdone Tomi Valkeinen
2020-03-16 10:05 ` Hans Verkuil
2020-03-16 10:11 ` Tomi Valkeinen
2020-03-16 12:43 ` Laurent Pinchart
2020-03-17 11:34 ` Tomi Valkeinen
2020-03-13 11:41 ` [PATCH 15/16] media: ti-vpe: cal: improve wait for stop-state Tomi Valkeinen
2020-03-16 12:45 ` Laurent Pinchart
2020-03-17 11:44 ` Tomi Valkeinen
2020-03-13 11:41 ` [PATCH 16/16] media: ti-vpe: cal: fix stop state timeout Tomi Valkeinen
2020-03-16 12:49 ` Laurent Pinchart
2020-03-16 12:28 ` [PATCH 01/16] media: ti-vpe: cal: fix use of wrong macro Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316123129.GZ4732@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bparrot@ti.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox