From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E050C18E5B for ; Mon, 16 Mar 2020 12:39:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CED04206E2 for ; Mon, 16 Mar 2020 12:39:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ufEpETLN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731216AbgCPMje (ORCPT ); Mon, 16 Mar 2020 08:39:34 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:35846 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731050AbgCPMjd (ORCPT ); Mon, 16 Mar 2020 08:39:33 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D7AAA3B; Mon, 16 Mar 2020 13:39:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1584362372; bh=8MWreaBOOcT2ES4I84mlWsjXYrL44X8hB9WbBBHOfX0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ufEpETLNkl5xRZrbJrPVtpVsEtupBC1E1XCMfjcPjw0OCT0EtkrkCSko3UrCCzAvY kHC6EOXpqZdhpkpj0dcSm5ZWHOl9cTPeDXsz0bb91Xov1+Pr+1dD3USmj2bsGUhzyE LsgmjsC8+M89VwkRyF9dKb5lbteSaI5D1cShkZ1E= Date: Mon, 16 Mar 2020 14:39:27 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: linux-media@vger.kernel.org, Benoit Parrot , Mauro Carvalho Chehab Subject: Re: [PATCH 12/16] media: ti-vpe: cal: set DMA max seg size Message-ID: <20200316123927.GE4732@pendragon.ideasonboard.com> References: <20200313114121.32182-1-tomi.valkeinen@ti.com> <20200313114121.32182-12-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200313114121.32182-12-tomi.valkeinen@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Mar 13, 2020 at 01:41:17PM +0200, Tomi Valkeinen wrote: > Set DMA max seg size correctly to get rid of warnings on 64 bit > platforms: > > DMA-API: cal 6f03000.cal: mapping sg segment longer than device claims to support [len=720896] [max=65536] > > Signed-off-by: Tomi Valkeinen > --- > drivers/media/platform/ti-vpe/cal.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c > index 832f37ebad0d..64ea92dbfac5 100644 > --- a/drivers/media/platform/ti-vpe/cal.c > +++ b/drivers/media/platform/ti-vpe/cal.c > @@ -2321,6 +2321,8 @@ static int cal_probe(struct platform_device *pdev) > return -ENODEV; > } > > + vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); > + > pm_runtime_enable(&pdev->dev); > > ret = cal_runtime_get(dev); > @@ -2335,6 +2337,8 @@ static int cal_probe(struct platform_device *pdev) > return 0; > > runtime_disable: > + vb2_dma_contig_clear_max_seg_size(&pdev->dev); > + It's probably time to fix this horrible DMA API that requires such cleanups, but that's out of scope for this patch. Reviewed-by: Laurent Pinchart > pm_runtime_disable(&pdev->dev); > for (i = 0; i < CAL_NUM_CONTEXT; i++) { > ctx = dev->ctx[i]; > @@ -2377,6 +2381,8 @@ static int cal_remove(struct platform_device *pdev) > cal_runtime_put(dev); > pm_runtime_disable(&pdev->dev); > > + vb2_dma_contig_clear_max_seg_size(&pdev->dev); > + > return 0; > } > -- Regards, Laurent Pinchart