From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D970CC4332B for ; Fri, 20 Mar 2020 15:13:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD6F12072C for ; Fri, 20 Mar 2020 15:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584717189; bh=J/oGZu0Dj9B02ICX042R2cJnLloUnidiS6P64XmuALU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=xQYuV4yPgvU68M1dKn7skZoldTctSn0jeN2M9q4bT2iWk6ATaN5CoyeuahdDnT9ys zijlc2HB3ihB075vL7nUZBotnn4qiyjYo2QDnQc34VECBtjXLV5chZqiwEzPNHYl0x YLJe3KPssQhuUKmEAAsNa0EHWBcrsYG9roU2I4Lc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727312AbgCTPNG (ORCPT ); Fri, 20 Mar 2020 11:13:06 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:56890 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726778AbgCTPNF (ORCPT ); Fri, 20 Mar 2020 11:13:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=93fJ0tgtJJHIzWZuQEDx6f5mym0h69xksF0VgXuE8Kk=; b=fSI+RzboPVuOVxen7dYeYOCzXv q2vGzfi5990iKvXKKC6Zw9mhK0I+RJ8QVQ3izGashIvvIa1JNPx+JV1/bnlfvrqpZoNhTCBLogIE9 DhNFZE90ZORoFrh4TJI+isNTQkTmCjXdsg75iUpjQYbh484XebG/BT0g0A8C4DwkDaqFZWeIR81ns PlAxUfXGCD2hNWp1UOUAkjD2Wvq6ukjn8sc07iflvxlyl1Bv4ZIk2qjnDcpsgL4KmcwthB7g8Ccmv bZzsmiqZaZIce/mx6641uu0I6uQI+dZWu76Ib0Mr0zsS9Rp7BYZuUSr2zcPTzNP3zx/cwlZdC/UzK qd0b1TVA==; Received: from ip5f5ad4e9.dynamic.kabel-deutschland.de ([95.90.212.233] helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jFJKa-0004CT-Uk; Fri, 20 Mar 2020 15:13:05 +0000 Date: Fri, 20 Mar 2020 16:13:01 +0100 From: Mauro Carvalho Chehab To: Martin Knoblauch Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: Build error on 5.5.10 after activating v4l in .config Message-ID: <20200320161301.36866c31@coco.lan> In-Reply-To: References: X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Fri, 20 Mar 2020 15:56:16 +0100 Martin Knoblauch escreveu: > Hi, (sesending without attachment) > > today I tried to build 5.5.10 based on a working 5.5.6 configuration. I > also enabled v4l in the configuration using menuconfig. This resulted in > the following build error: > > AS arch/x86/boot/compressed/efi_thunk_64.o > CC arch/x86/boot/compressed/misc.o > XZKERN arch/x86/boot/compressed/vmlinux.bin.xz > ERROR: "__devm_regmap_init_i2c" [drivers/media/i2c/tvp5150.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 > make: *** [Makefile:1282: modules] Error 2 > make: *** Waiting for unfinished jobs.... > > After some searching the universal support tool, I applied the following > patch: > > --- ./drivers/media/i2c/Kconfig-orig 2020-03-18 13:57:30.288639392 +0100 > +++ ./drivers/media/i2c/Kconfig 2020-03-18 16:44:03.938384192 +0100 > @@ -378,6 +378,7 @@ > config VIDEO_TVP5150 > tristate "Texas Instruments TVP5150 video decoder" > depends on VIDEO_V4L2 && I2C > + select REGMAP_I2C > select V4L2_FWNODE > help > Support for the Texas Instruments TVP5150 video decoder. > > This made my build work again. But I am absolutely not sure this is the > right fix or whether it is complete. Yes, it is. There are other places where the same select is needed. There's already a patch upstream (linux-next) addressing this issue. It should be merged for 5.7. Regards, Mauro