From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: linux-media@vger.kernel.org, libcamera-devel@lists.libcamera.org,
hverkuil-cisco@xs4all.nl, mchehab@kernel.org,
sakari.ailus@linux.intel.com
Subject: Re: [libcamera-devel] [PATCH 4/4] media: bcm2835: Fix trivial whitespace error
Date: Tue, 24 Mar 2020 22:46:16 +0200 [thread overview]
Message-ID: <20200324204616.GD20997@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200324202844.1518292-5-jacopo@jmondi.org>
Hi Jacopo,
Thank you for the patch.
On Tue, Mar 24, 2020 at 09:28:44PM +0100, Jacopo Mondi wrote:
> Cosmetic change only.
>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
> drivers/media/platform/bcm2835/bcm2835-unicam.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/bcm2835/bcm2835-unicam.c b/drivers/media/platform/bcm2835/bcm2835-unicam.c
> index 5001976dcebc..65534a18d3d4 100644
> --- a/drivers/media/platform/bcm2835/bcm2835-unicam.c
> +++ b/drivers/media/platform/bcm2835/bcm2835-unicam.c
> @@ -2462,7 +2462,7 @@ static int unicam_set_ctrl(struct v4l2_ctrl *ctrl)
> /* Change the number of frames of delay we believe there
> * to be between updating analogue gain and it taking effect.
> */
> - return unicam_update_delay(unicam,
> + return unicam_update_delay(unicam,
> V4L2_CID_ANALOGUE_GAIN, ctrl->val);
While at it, write it
return unicam_update_delay(unicam, V4L2_CID_ANALOGUE_GAIN,
ctrl->val);
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> default:
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-03-24 20:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 20:28 [PATCH 0/4] media: Register read-only sub-dev devnode Jacopo Mondi
2020-03-24 20:28 ` [PATCH 1/4] Documentation: media: Document read-only subdevice Jacopo Mondi
2020-03-25 21:37 ` [libcamera-devel] " Laurent Pinchart
2020-03-25 22:38 ` Laurent Pinchart
2020-03-24 20:28 ` [PATCH 2/4] media: v4l2-dev: Add v4l2_device_register_ro_subdev_node() Jacopo Mondi
2020-03-25 8:42 ` [libcamera-devel] " Andrey Konovalov
2020-03-25 11:23 ` Jacopo Mondi
2020-03-26 0:08 ` Sakari Ailus
2020-03-25 21:45 ` Laurent Pinchart
2020-03-25 22:57 ` Jacopo Mondi
2020-03-24 20:28 ` [PATCH 3/4] media: bcm2835: Register sensor devnode as read-only Jacopo Mondi
2020-03-24 20:28 ` [PATCH 4/4] media: bcm2835: Fix trivial whitespace error Jacopo Mondi
2020-03-24 20:46 ` Laurent Pinchart [this message]
2020-03-24 22:25 ` [libcamera-devel] [PATCH 0/4] media: Register read-only sub-dev devnode Dave Stevenson
2020-03-24 23:37 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324204616.GD20997@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=libcamera-devel@lists.libcamera.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).