From: DEEPAK VARMA <mh12gx2825@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Baluta <daniel.baluta@gmail.com>,
kieran.bingham@ideasonboard.com,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization
Date: Thu, 26 Mar 2020 02:18:49 +0530 [thread overview]
Message-ID: <20200325204844.GA30732@deeUbuntu> (raw)
In-Reply-To: <20200323151710.GA22110@deeUbuntu>
Adding Linux-media list as advised by Sakari Ailus.
On Mon, Mar 23, 2020 at 08:47:12PM +0530, DEEPAK VARMA wrote:
> On Mon, Mar 23, 2020 at 01:35:58AM +0200, Andy Shevchenko wrote:
> > On Sun, Mar 22, 2020 at 8:54 PM Deepak R Varma <mh12gx2825@gmail.com> wrote:
> > >
> > > Reformat pointer initialization to make it more readable as per the
> > > coding standards. Problem detected by checkpatch.
> >
> > > - struct imgu_v4l2_subdev *imgu_sd =
> > > - container_of(ctrl->handler, struct imgu_v4l2_subdev, ctrl_handler);
> > > + struct imgu_v4l2_subdev *imgu_sd = container_of(ctrl->handler,
> > > + struct imgu_v4l2_subdev,
> > > + ctrl_handler);
> >
> > I'm sorry I don't see benefit of this change, actually an opposite.
>
> Hello Andy,
> Thank you for your comment. To me, it helps quickly and clearly spot
> *imgu_sd. Also the initialization looks more structured. But that's just
> me.
>
> I will wait to see if anyone else wants to share their thoughts, and
> then circle back to you on next steps. Is that fine?
>
Hello Andy and all,
I have not seen any additional comments on this thread. Let me know if
you approve the proposed change or want me to leave it as is.
Thank you,
Deepak.
> Deepak.
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
parent reply other threads:[~2020-03-25 20:49 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200323151710.GA22110@deeUbuntu>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325204844.GA30732@deeUbuntu \
--to=mh12gx2825@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).