From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Steve Longerbeam <slongerbeam@gmail.com>
Cc: linux-media@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v4 16/17] media: imx: silence a couple debug messages
Date: Wed, 15 Apr 2020 02:33:10 +0300 [thread overview]
Message-ID: <20200414233310.GE28533@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200303234256.8928-17-slongerbeam@gmail.com>
Hi Steve,
Thank you for the patch.
On Tue, Mar 03, 2020 at 03:42:55PM -0800, Steve Longerbeam wrote:
> Convert to dev_dbg the "subdev bound" and IPU-internal media-link
> creation messages.
>
> Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/staging/media/imx/imx-media-dev-common.c | 4 +++-
> drivers/staging/media/imx/imx-media-dev.c | 2 +-
> drivers/staging/media/imx/imx-media-internal-sd.c | 6 +++---
> 3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-dev-common.c b/drivers/staging/media/imx/imx-media-dev-common.c
> index f7ad3cbbeec2..b23bbfab388a 100644
> --- a/drivers/staging/media/imx/imx-media-dev-common.c
> +++ b/drivers/staging/media/imx/imx-media-dev-common.c
> @@ -24,7 +24,9 @@ static int imx_media_subdev_bound(struct v4l2_async_notifier *notifier,
> struct v4l2_subdev *sd,
> struct v4l2_async_subdev *asd)
> {
> - v4l2_info(sd->v4l2_dev, "subdev %s bound\n", sd->name);
> + struct imx_media_dev *imxmd = notifier2dev(notifier);
> +
> + dev_dbg(imxmd->md.dev, "subdev %s bound\n", sd->name);
>
> return 0;
> }
> diff --git a/drivers/staging/media/imx/imx-media-dev.c b/drivers/staging/media/imx/imx-media-dev.c
> index 2c3c2adca683..6d2205461e56 100644
> --- a/drivers/staging/media/imx/imx-media-dev.c
> +++ b/drivers/staging/media/imx/imx-media-dev.c
> @@ -32,7 +32,7 @@ static int imx_media_subdev_bound(struct v4l2_async_notifier *notifier,
> return ret;
> }
>
> - v4l2_info(&imxmd->v4l2_dev, "subdev %s bound\n", sd->name);
> + dev_dbg(imxmd->md.dev, "subdev %s bound\n", sd->name);
>
> return 0;
> }
> diff --git a/drivers/staging/media/imx/imx-media-internal-sd.c b/drivers/staging/media/imx/imx-media-internal-sd.c
> index d4237e1a4241..da4109b2fd13 100644
> --- a/drivers/staging/media/imx/imx-media-internal-sd.c
> +++ b/drivers/staging/media/imx/imx-media-internal-sd.c
> @@ -142,9 +142,9 @@ static int create_internal_link(struct imx_media_dev *imxmd,
> &sink->entity.pads[link->remote_pad]))
> return 0;
>
> - v4l2_info(&imxmd->v4l2_dev, "%s:%d -> %s:%d\n",
> - src->name, link->local_pad,
> - sink->name, link->remote_pad);
> + dev_dbg(imxmd->md.dev, "%s:%d -> %s:%d\n",
> + src->name, link->local_pad,
> + sink->name, link->remote_pad);
>
> ret = media_create_pad_link(&src->entity, link->local_pad,
> &sink->entity, link->remote_pad, 0);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-04-14 23:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 23:42 [PATCH v4 00/17] media: imx: Create media links in bound notifiers Steve Longerbeam
2020-03-03 23:42 ` [PATCH v4 01/17] media: entity: Pass entity to get_fwnode_pad operation Steve Longerbeam
2020-04-14 22:58 ` Laurent Pinchart
2020-03-03 23:42 ` [PATCH v4 02/17] media: video-mux: Parse information from firmware without using callbacks Steve Longerbeam
2020-03-03 23:42 ` [PATCH v4 03/17] media: imx: " Steve Longerbeam
2020-03-03 23:42 ` [PATCH v4 04/17] Revert "media: v4l2-fwnode: Add a convenience function for registering subdevs with notifiers" Steve Longerbeam
2020-03-03 23:42 ` [PATCH v4 05/17] media: imx: csi: Implement get_fwnode_pad op Steve Longerbeam
2020-04-14 23:02 ` Laurent Pinchart
2020-03-03 23:42 ` [PATCH v4 06/17] media: imx: mipi csi-2: " Steve Longerbeam
2020-04-14 23:07 ` Laurent Pinchart
2020-04-14 23:20 ` Sakari Ailus
2020-04-14 23:27 ` Laurent Pinchart
2020-04-14 23:56 ` Sakari Ailus
2020-04-14 23:50 ` Steve Longerbeam
2020-04-15 0:43 ` Laurent Pinchart
2020-04-14 23:29 ` Steve Longerbeam
2020-03-03 23:42 ` [PATCH v4 07/17] media: video-mux: " Steve Longerbeam
2020-04-14 23:08 ` Laurent Pinchart
2020-04-15 0:17 ` Steve Longerbeam
2020-03-03 23:42 ` [PATCH v4 08/17] media: imx: Add imx_media_create_fwnode_pad_link() Steve Longerbeam
2020-04-14 23:21 ` Laurent Pinchart
2020-03-03 23:42 ` [PATCH v4 09/17] media: video-mux: Create media links in bound notifier Steve Longerbeam
2020-04-14 23:16 ` Laurent Pinchart
2020-04-14 23:47 ` Steve Longerbeam
2020-04-18 0:56 ` Steve Longerbeam
2020-03-03 23:42 ` [PATCH v4 10/17] media: imx: mipi csi-2: " Steve Longerbeam
2020-03-03 23:42 ` [PATCH v4 11/17] media: imx7: mipi csis: " Steve Longerbeam
2020-03-03 23:42 ` [PATCH v4 12/17] media: imx7: csi: " Steve Longerbeam
2020-03-03 23:42 ` [PATCH v4 13/17] media: imx: " Steve Longerbeam
2020-03-03 23:42 ` [PATCH v4 14/17] media: imx: csi: Lookup upstream endpoint with imx_media_get_pad_fwnode Steve Longerbeam
2020-04-14 23:24 ` Laurent Pinchart
2020-03-03 23:42 ` [PATCH v4 15/17] media: imx: Create missing links from CSI-2 receiver Steve Longerbeam
2020-04-14 23:32 ` Laurent Pinchart
2020-04-15 0:10 ` Steve Longerbeam
2020-03-03 23:42 ` [PATCH v4 16/17] media: imx: silence a couple debug messages Steve Longerbeam
2020-04-14 23:33 ` Laurent Pinchart [this message]
2020-03-03 23:42 ` [PATCH v4 17/17] media: imx: TODO: Remove media link creation todos Steve Longerbeam
2020-03-25 18:09 ` [PATCH v4 00/17] media: imx: Create media links in bound notifiers Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414233310.GE28533@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rmfrfs@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox