From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 137CBC2BB1D for ; Wed, 15 Apr 2020 00:43:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4BF2206D9 for ; Wed, 15 Apr 2020 00:43:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="p8FXfzk+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407889AbgDOAnp (ORCPT ); Tue, 14 Apr 2020 20:43:45 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:39210 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407887AbgDOAnm (ORCPT ); Tue, 14 Apr 2020 20:43:42 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C7781521; Wed, 15 Apr 2020 02:43:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586911418; bh=a4tMpEbfop26maOFWO9qNYXEanaQDSNa+tMbiX5hcIo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p8FXfzk+xEvshkoNCJrNe99FMPw5QES2ukJsUHhlDHiexZxEZLaF01BUhX+cIgzbH hwdvgZfaI1u9Gp8LVpxYao3tsm5TEIsMbn/1mFcU0WdKpf2T9PwW5XKbelDLSkgH4Z NPhBZGSw+GDyYTuMQ1aFC+buaW+TMZNJDTp9fw7I= Date: Wed, 15 Apr 2020 03:43:26 +0300 From: Laurent Pinchart To: Steve Longerbeam Cc: Sakari Ailus , linux-media@vger.kernel.org, Mauro Carvalho Chehab , Hans Verkuil , Rui Miguel Silva , Philipp Zabel Subject: Re: [PATCH v4 06/17] media: imx: mipi csi-2: Implement get_fwnode_pad op Message-ID: <20200415004326.GX19819@pendragon.ideasonboard.com> References: <20200303234256.8928-1-slongerbeam@gmail.com> <20200303234256.8928-7-slongerbeam@gmail.com> <20200414230729.GC27621@pendragon.ideasonboard.com> <20200414232036.GB27762@paasikivi.fi.intel.com> <6d8b82c4-be84-4722-4f5a-558b5ffe7b80@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6d8b82c4-be84-4722-4f5a-558b5ffe7b80@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Steve, On Tue, Apr 14, 2020 at 04:50:55PM -0700, Steve Longerbeam wrote: > On 4/14/20 4:20 PM, Sakari Ailus wrote: > > On Wed, Apr 15, 2020 at 02:07:29AM +0300, Laurent Pinchart wrote: > >> On Tue, Mar 03, 2020 at 03:42:45PM -0800, Steve Longerbeam wrote: > >>> Implement get_fwnode_pad operation. If the endpoint is owned by the MIPI > >>> CSI-2 receiver, return the endpoint's port number. The MIPI CSI-2 receiver > >>> maps port numbers and pad indexes 1:1. > >>> > >>> Signed-off-by: Steve Longerbeam > >>> --- > >>> drivers/staging/media/imx/imx6-mipi-csi2.c | 28 ++++++++++++++++++++++ > >>> 1 file changed, 28 insertions(+) > >>> > >>> diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/staging/media/imx/imx6-mipi-csi2.c > >>> index fdd763587e6c..8500207e5ea9 100644 > >>> --- a/drivers/staging/media/imx/imx6-mipi-csi2.c > >>> +++ b/drivers/staging/media/imx/imx6-mipi-csi2.c > >>> @@ -507,9 +507,37 @@ static int csi2_registered(struct v4l2_subdev *sd) > >>> 640, 480, 0, V4L2_FIELD_NONE, NULL); > >>> } > >>> > >>> +static int csi2_get_fwnode_pad(struct media_entity *entity, > >>> + struct fwnode_endpoint *endpoint) > >>> +{ > >>> + struct v4l2_subdev *sd = media_entity_to_v4l2_subdev(entity); > >>> + struct csi2_dev *csi2 = sd_to_dev(sd); > >>> + struct fwnode_handle *csi2_ep; > >>> + > >>> + /* > >>> + * If the endpoint is one of ours, return the endpoint's port > >>> + * number. This device maps port numbers and pad indexes 1:1. > >>> + */ > >>> + fwnode_graph_for_each_endpoint(dev_fwnode(csi2->dev), csi2_ep) { > >>> + if (endpoint->local_fwnode == csi2_ep) { > >>> + struct fwnode_endpoint fwep; > >>> + int ret; > >>> + > >>> + ret = fwnode_graph_parse_endpoint(csi2_ep, &fwep); > >>> + > >>> + fwnode_handle_put(csi2_ep); > >>> + > >>> + return ret ? ret : fwep.port; > >>> + } > >>> + } > >>> + > >>> + return -ENXIO; > >>> +} > >> > >> As the 1:1 mapping is the common case, would it make sense to modify > >> media_entity_get_fwnode_pad() accordingly when .get_fwnode_pad is not > >> set ? The current behaviour is to return the first pad that matches the > > > > I also think this would make sense. > > What do you think about https://patchwork.linuxtv.org/patch/60312/ ? I'm > planning to resurrect it for v5. The approach looks good to me. > >> requested direction, which could be preserved as a second-level fallback > >> if the 1:1 mapping doesn't give the right direction (but I'm not sure > >> there's a use case for that, the 1:1 mapping seems to be all we need if > >> there's no specific .get_fwnode_pad implementation). > > > > I believe at least the smiapp driver breaks if you do that, so the current > > behaviour should be retained (secondary to the 1:1 mapping). -- Regards, Laurent Pinchart