[PATCH 1/3] media: cec: don't select PCI & DMI

[PATCH 1/3] media: cec: don't select PCI & DMI

[Mauro Carvalho Chehab]

While select would be a great idea for most archs, this
causes a breakage with s390:

	"I don't think that's a good idea, as it suddenly enables selecting all PCI
	 drivers on platforms that do not have PCI.

	    WARNING: unmet direct dependencies detected for PCI
	      Depends on [n]: HAVE_PCI [=n]
	      Selected by [m]:
	      - CEC_SECO [=m] && MEDIA_CEC_SUPPORT [=y] && (X86 || IA64 || COMPILE_TEST [=y])

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
 drivers/media/cec/platform/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/cec/platform/Kconfig b/drivers/media/cec/platform/Kconfig
index 2c4dd7401dd8..350533cd8261 100644
--- a/drivers/media/cec/platform/Kconfig
+++ b/drivers/media/cec/platform/Kconfig
@@ -100,8 +100,7 @@ config CEC_TEGRA
 config CEC_SECO
 	tristate "SECO Boards HDMI CEC driver"
 	depends on (X86 || IA64) || COMPILE_TEST
-	select PCI
-	select DMI
+	depends on PCI && DMI
 	select CEC_CORE
 	select CEC_NOTIFIER
 	help
-- 
2.25.2

[PATCH 2/3] media: mc/Kconfig: remove staging dependency for request API

[Mauro Carvalho Chehab]

When the request API got merged, only drivers at staging were
using it. As we wanted to be able to do future changes on it,
we added an artificial depends on STAGING_MEDIA.

Yet, request API is there for quite some time now, and
didn't suffer any API breakages during this time. So, drop
this.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Suggested-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
 drivers/media/mc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/mc/Kconfig b/drivers/media/mc/Kconfig
index 7c9628f37196..4815b9dde9af 100644
--- a/drivers/media/mc/Kconfig
+++ b/drivers/media/mc/Kconfig
@@ -14,7 +14,7 @@ config MEDIA_CONTROLLER_DVB
 
 config MEDIA_CONTROLLER_REQUEST_API
 	bool
-	depends on MEDIA_CONTROLLER && STAGING_MEDIA
+	depends on MEDIA_CONTROLLER
 	help
 	  DO NOT ENABLE THIS OPTION UNLESS YOU KNOW WHAT YOU'RE DOING.
 
-- 
2.25.2

[PATCH 3/3] media: cec/usb: depends on USB_SUPPORT and TTY

[Mauro Carvalho Chehab]

As reported by Randy:

	WARNING: unmet direct dependencies detected for USB
	  Depends on [n]: USB_SUPPORT [=n] && USB_ARCH_HAS_HCD [=n]
	  Selected by [m]:
	  - USB_RAINSHADOW_CEC [=m] && MEDIA_CEC_SUPPORT [=y]

	WARNING: unmet direct dependencies detected for USB_ACM
	  Depends on [n]: USB_SUPPORT [=n] && USB [=m] && TTY [=n]
	  Selected by [m]:
	  - USB_RAINSHADOW_CEC [=m] && MEDIA_CEC_SUPPORT [=y]

in order to be able to select USB_ACM, we need both USB_SUPPORT
and TTY. So, depends on those two.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
 drivers/media/cec/usb/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/cec/usb/Kconfig b/drivers/media/cec/usb/Kconfig
index d3bbef464bdb..3f3a5c75287a 100644
--- a/drivers/media/cec/usb/Kconfig
+++ b/drivers/media/cec/usb/Kconfig
@@ -2,5 +2,7 @@
 #
 # USB drivers
 
+if USB_SUPPORT && TTY
 source "drivers/media/cec/usb/pulse8/Kconfig"
 source "drivers/media/cec/usb/rainshadow/Kconfig"
+endif
-- 
2.25.2

Re: [PATCH 1/3] media: cec: don't select PCI & DMI

[Geert Uytterhoeven]

Hi Mauro,

On Fri, Apr 17, 2020 at 9:08 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
> While select would be a great idea for most archs, this
> causes a breakage with s390:
>
>         "I don't think that's a good idea, as it suddenly enables selecting all PCI
>          drivers on platforms that do not have PCI.
>
>             WARNING: unmet direct dependencies detected for PCI
>               Depends on [n]: HAVE_PCI [=n]
>               Selected by [m]:
>               - CEC_SECO [=m] && MEDIA_CEC_SUPPORT [=y] && (X86 || IA64 || COMPILE_TEST [=y])
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Thanks for your patch!

Fixes: 4be5e8648b0c287a ("media: move CEC platform drivers to a
separate directory")
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/3] media: cec: don't select PCI & DMI

[Mauro Carvalho Chehab]

Em Fri, 17 Apr 2020 09:30:51 +0200
Geert Uytterhoeven <geert@linux-m68k.org> escreveu:

> Hi Mauro,
> 
> On Fri, Apr 17, 2020 at 9:08 AM Mauro Carvalho Chehab
> <mchehab+huawei@kernel.org> wrote:
> > While select would be a great idea for most archs, this
> > causes a breakage with s390:
> >
> >         "I don't think that's a good idea, as it suddenly enables selecting all PCI
> >          drivers on platforms that do not have PCI.
> >
> >             WARNING: unmet direct dependencies detected for PCI
> >               Depends on [n]: HAVE_PCI [=n]
> >               Selected by [m]:
> >               - CEC_SECO [=m] && MEDIA_CEC_SUPPORT [=y] && (X86 || IA64 || COMPILE_TEST [=y])
> >
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>  
> 
> Thanks for your patch!
> 
> Fixes: 4be5e8648b0c287a ("media: move CEC platform drivers to a
> separate directory")
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Btw, I almost solved it on a different way, keeping the select and making
it depends on HAVE_PCI.

I ended by opting to do this change in order to try to avoid more
Kconfig noise (and because "select PCI" is not popular those days).

Thanks,
Mauro

Re: [PATCH 1/3] media: cec: don't select PCI & DMI

[Geert Uytterhoeven]

Hi Mauro,

On Fri, Apr 17, 2020 at 9:34 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
> Em Fri, 17 Apr 2020 09:30:51 +0200
> Geert Uytterhoeven <geert@linux-m68k.org> escreveu:
> > On Fri, Apr 17, 2020 at 9:08 AM Mauro Carvalho Chehab
> > <mchehab+huawei@kernel.org> wrote:
> > > While select would be a great idea for most archs, this
> > > causes a breakage with s390:
> > >
> > >         "I don't think that's a good idea, as it suddenly enables selecting all PCI
> > >          drivers on platforms that do not have PCI.
> > >
> > >             WARNING: unmet direct dependencies detected for PCI
> > >               Depends on [n]: HAVE_PCI [=n]
> > >               Selected by [m]:
> > >               - CEC_SECO [=m] && MEDIA_CEC_SUPPORT [=y] && (X86 || IA64 || COMPILE_TEST [=y])
> > >
> > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> >
> > Thanks for your patch!
> >
> > Fixes: 4be5e8648b0c287a ("media: move CEC platform drivers to a
> > separate directory")
> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Btw, I almost solved it on a different way, keeping the select and making
> it depends on HAVE_PCI.

Like you did for the similar change to USB?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/3] media: cec: don't select PCI & DMI

[Mauro Carvalho Chehab]

Em Fri, 17 Apr 2020 09:52:02 +0200
Geert Uytterhoeven <geert@linux-m68k.org> escreveu:

> Hi Mauro,
> 
> On Fri, Apr 17, 2020 at 9:34 AM Mauro Carvalho Chehab
> <mchehab+huawei@kernel.org> wrote:
> > Em Fri, 17 Apr 2020 09:30:51 +0200
> > Geert Uytterhoeven <geert@linux-m68k.org> escreveu:  
> > > On Fri, Apr 17, 2020 at 9:08 AM Mauro Carvalho Chehab
> > > <mchehab+huawei@kernel.org> wrote:  
> > > > While select would be a great idea for most archs, this
> > > > causes a breakage with s390:
> > > >
> > > >         "I don't think that's a good idea, as it suddenly enables selecting all PCI
> > > >          drivers on platforms that do not have PCI.
> > > >
> > > >             WARNING: unmet direct dependencies detected for PCI
> > > >               Depends on [n]: HAVE_PCI [=n]
> > > >               Selected by [m]:
> > > >               - CEC_SECO [=m] && MEDIA_CEC_SUPPORT [=y] && (X86 || IA64 || COMPILE_TEST [=y])
> > > >
> > > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>  
> > >
> > > Thanks for your patch!
> > >
> > > Fixes: 4be5e8648b0c287a ("media: move CEC platform drivers to a
> > > separate directory")
> > > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>  
> >
> > Btw, I almost solved it on a different way, keeping the select and making
> > it depends on HAVE_PCI.  
> 
> Like you did for the similar change to USB?

Yes.

The thing is: there are several other drivers that already select USB
(and one driver selecting USB_ACM). So, this didn't sound too risky.

On the other hand, there's currently nothing selecting "PCI". So,
in order to avoid more (possible) Kconfig noise, I opted to be
more conservative here.

Thanks,
Mauro