From: Dan Carpenter <dan.carpenter@oracle.com>
To: hans.verkuil@cisco.com
Cc: linux-media@vger.kernel.org
Subject: [bug report] media: cec-gpio: add HDMI CEC GPIO driver
Date: Sat, 18 Apr 2020 20:16:23 +0300 [thread overview]
Message-ID: <20200418171623.GA801737@mwanda> (raw)
Hello Hans Verkuil,
The patch 1e33936d3bae: "media: cec-gpio: add HDMI CEC GPIO driver"
from Jun 28, 2017, leads to the following static checker warning:
drivers/media/cec/platform/cec-gpio/cec-gpio.c:40 cec_gpio_read()
warn: signedness bug returning '(-4095)'
drivers/media/cec/platform/cec-gpio/cec-gpio.c
34 static bool cec_gpio_read(struct cec_adapter *adap)
35 {
36 struct cec_gpio *cec = cec_get_drvdata(adap);
37
38 if (cec->cec_is_low)
39 return false;
40 return gpiod_get_value(cec->cec_gpio);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
negative error codes become "true".
41 }
regards,
dan carpenter
reply other threads:[~2020-04-18 17:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200418171623.GA801737@mwanda \
--to=dan.carpenter@oracle.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).