From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C44FC55181 for ; Tue, 21 Apr 2020 08:05:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B91720B1F for ; Tue, 21 Apr 2020 08:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587456349; bh=MIsMOSthC5x1b/v9D2P+kZ/IzkE0C1W/5y/jCBKmXJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WLzMYy+jQBh6orMVriLB94UqfGjPSogsJZBhFkdqy2Udmze27pqG2RRgGUPZI6jHf ZmV0a12plsCwVx7EdgGt9o3MFosfABQEwJtcPYLfqXW4fx1OO35/mmpzTGF+BXqzXt RM0OWfmyXw4ymRuoXmaKPmJt6hKARjTLFLYbyKvI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728055AbgDUIFs (ORCPT ); Tue, 21 Apr 2020 04:05:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:34978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726691AbgDUIFr (ORCPT ); Tue, 21 Apr 2020 04:05:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 557F32071C; Tue, 21 Apr 2020 08:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587456346; bh=MIsMOSthC5x1b/v9D2P+kZ/IzkE0C1W/5y/jCBKmXJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yu5yyQyNv4XIUAiv3IrPdT9binnqLDUcLtF7ShkV4r61pPbSv6Au4+iJXCqCjh/fi tiP+gTI/LQ36uKxAfSnU3sqBXrqR2nA9HcuR6BUtj+q2brAM+lrlX6zkJZbvB/18Vw jcZFKMEUb0ULBEhzpnRvj1BNYgQDXY0zSfDsD9ng= Date: Tue, 21 Apr 2020 10:05:44 +0200 From: Greg Kroah-Hartman To: John Stultz Cc: Christian Brauner , driverdevel , nd , Todd Kjos , Lecopzer Chen , Arnd Bergmann , Laura Abbott , lkml , dri-devel , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Anders Pedersen , Daniel Vetter , Joel Fernandes , "Darren Hart (VMware)" , =?iso-8859-1?Q?=D8rjan?= Eide , Laura Abbott , Martijn Coenen , Sumit Semwal , Christian Brauner , linux-media@vger.kernel.org Subject: Re: [PATCH] staging: android: ion: Skip sync if not mapped Message-ID: <20200421080544.GA611314@kroah.com> References: <20200414134629.54567-1-orjan.eide@arm.com> <20200414141849.55654-1-orjan.eide@arm.com> <20200414142810.GA958163@kroah.com> <20200416102508.GA820251@kroah.com> <20200420082207.ui7iyg7dsnred2vv@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Apr 20, 2020 at 01:03:39PM -0700, John Stultz wrote: > On Mon, Apr 20, 2020 at 1:22 AM Christian Brauner > wrote: > > On Thu, Apr 16, 2020 at 12:25:08PM +0200, Greg Kroah-Hartman wrote: > > > On Tue, Apr 14, 2020 at 09:41:31PM -0700, John Stultz wrote: > > > > But I do think we can mark it as deprecated and let folks know that > > > > around the end of the year it will be deleted. > > > > > > No one ever notices "depreciated" things, they only notice if the code > > > is no longer there :) > > > > > > So I'm all for just deleting it and seeing who even notices... > > > > Agreed. > > I mean, I get there's not much love for ION in staging, and I too am > eager to see it go, but I also feel like in the discussions around > submitting the dmabuf heaps at talks, etc, that there was clear value > in removing ION after a short time so that folks could transition > being able to test both implementations against the same kernel so > performance regressions, etc could be worked out. > > I am actively getting many requests for help for vendors who are > looking at dmabuf heaps and are starting the transition process, and > I'm trying my best to motivate them to directly work within the > community so their needed heap functionality can go upstream. But it's > going to be a process, and their first attempts aren't going to > magically land upstream. I think being able to really compare their > implementations as they iterate and push things upstream will help in > order to be able to have upstream solutions that are also properly > functional for production usage. But we are not accepting any new ion allocators or changes at the moment, so I don't see how the ion code in the kernel is helping/hurting anything here. There has been a bunch of changes to the ion code recently, in the Android kernel trees, in order to get a lot of the different manufacturer "forks" of ion back together into one place. But again, those patches are not going to be sent upstream for merging so how is ion affecting the dmabuf code at all here? > The dmabuf heaps have been in an official kernel now for all of three > weeks. So yea, we can "delete [ION] and see who even notices", but I > worry that may seem a bit like contempt for the folks doing the work > on transitioning over, which doesn't help getting them to participate > within the community. But they aren't participating in the community today as no one is touching the ion code. So I fail to see how keeping a dead-end-version of ion in the kernel tree really affects anyone these days. thanks, greg k-h