Re: HauppaugeTV-quadHD DVB-T mpeg risc op code error

[Sean Young <sean@mess.org>]

On Mon, Apr 27, 2020 at 09:03:22AM +0200, Martin Burnicki wrote:
> Martin Burnicki wrote:
> > Sean Young wrote:
> >> On Fri, Apr 24, 2020 at 07:46:26PM +0200, Martin Burnicki wrote:
> >>> I came across this thread and want to let you know that I also have
> >>> problems with the cx23885 driver on a Ryzen system.
> >>>
> >>> The only solution I found on the 'net that could make it work was to add
> >>> a line
> >>>
> >>> options cx23885 debug=7
> >>>
> >>> to the file /etc/modprobe.d/cx23885.conf
> >>
> >> Have you tried: 
> >>
> >> options cx23885 dma_reset_workaround=2
> > 
> > I think I remember I originally tried this when I set up this system,
> > and it didn't work, but that may not have been with a value of 2.
> 
> I've tried this now once more on my Ubuntu system with 5.3.0-46-generic,
> and indeed the workaround fixes the problem.
> 
> In case you are interested, here is the full dmesg output of the system
> when the error occurs if *no* workaround is enabled:
> 
> https://burnicki.net/martin/tmp/dmesg-with-error.txt
> 
> See the "mpeg risc op code error" message close to the bottom of the file.

Would you mind testing this patch please?

Thanks

Sean

From 216bd7f1a68de7a60bfa15a31f28343574bae313 Mon Sep 17 00:00:00 2001
From: Sean Young <sean@mess.org>
Date: Thu, 23 Apr 2020 17:28:09 +0100
Subject: [PATCH] media: cx23885: add a missing vid for other problematic AMD
 IOMMOs

The issue described in commit 95f408bbc4e4 ("media: cx23885: Ryzen DMA
related RiSC engine stall fixes") also affects this device.

Fixes: 95f408bbc4e4 ("media: cx23885: Ryzen DMA related RiSC engine stall fixes")

Cc: Brad Love <brad@nextdimension.cc>
Signed-off-by: Sean Young <sean@mess.org>
---
 drivers/media/pci/cx23885/cx23885-core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/pci/cx23885/cx23885-core.c b/drivers/media/pci/cx23885/cx23885-core.c
index 7e0b0b7cc2a3..f18c5017be84 100644
--- a/drivers/media/pci/cx23885/cx23885-core.c
+++ b/drivers/media/pci/cx23885/cx23885-core.c
@@ -2074,6 +2074,8 @@ static struct {
 	 * 0x1451 is PCI ID for the IOMMU found on Ryzen
 	 */
 	{ PCI_VENDOR_ID_AMD, 0x1451 },
+	{ PCI_VENDOR_ID_AMD, 0x1481 },
+	{ PCI_VENDOR_ID_AMD, 0x15d1 }, /* Raven2 IOMMU */
 };
 
 static bool cx23885_does_need_dma_reset(void)
-- 
2.25.4