From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF491C83000 for ; Tue, 28 Apr 2020 08:25:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95C44206B9 for ; Tue, 28 Apr 2020 08:25:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726621AbgD1IZU (ORCPT ); Tue, 28 Apr 2020 04:25:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726490AbgD1IZT (ORCPT ); Tue, 28 Apr 2020 04:25:19 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE9A4C03C1A9 for ; Tue, 28 Apr 2020 01:25:19 -0700 (PDT) Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTLYD-0005oz-3B; Tue, 28 Apr 2020 10:25:09 +0200 Received: from mfe by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jTLYA-0003sR-0V; Tue, 28 Apr 2020 10:25:06 +0200 Date: Tue, 28 Apr 2020 10:25:05 +0200 From: Marco Felsch To: Maxime Ripard Cc: Robert Foss , Rob Herring , Dongchun Zhu , Fabio Estevam , Andy Shevchenko , Sakari Ailus , Tomasz Figa , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [PATCH v7 1/3] media: dt-bindings: ov8856: Document YAML bindings Message-ID: <20200428082505.GA22489@pengutronix.de> References: <20200408110816.2712841-1-robert.foss@linaro.org> <20200408110816.2712841-2-robert.foss@linaro.org> <20200415160729.GA4438@bogus> <20200415162110.bmorj4u4hkqohqjx@pengutronix.de> <20200428075504.ovzugt2mbgan7z3k@gilmour.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428075504.ovzugt2mbgan7z3k@gilmour.lan> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:23:30 up 66 days, 19:40, 148 users, load average: 0.03, 0.16, 0.38 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::28 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 20-04-28 09:55, Maxime Ripard wrote: > On Mon, Apr 27, 2020 at 05:13:42PM +0200, Robert Foss wrote: > > On Wed, 15 Apr 2020 at 18:21, Marco Felsch wrote: > > > > > > On 20-04-15 11:07, Rob Herring wrote: > > > > On Wed, Apr 08, 2020 at 01:08:14PM +0200, Robert Foss wrote: > > > > > From: Dongchun Zhu ... > > > > > + clock-names: > > > > > + description: > > > > > + Input clock for the sensor. > > > > > + items: > > > > > + - const: xvclk > > > > > + > > > > > + assigned-clocks: > > > > > + description: > > > > > + Input clock for the sensor. > > > > > + > > > > > + assigned-clock-rates: > > > > > + description: > > > > > + Frequency of the xvclk clock in Hertz. > > > > > > > > These 2 should have a 'maxItems: 1' > > > > > > Don't know why those properties are needed here.. IMHO this shouldn't be > > > part of the binding or at least it should be optional and not required. > > > All we need is the clocks and the clock-names property. > > > > Thanks Marco, I'll make it optional for the next revision. > > Well, the whole discussion we had was about removing them entirely? +1 from my side. It is part of the system integration and not part of this device. Regards, Marco > Maxime