Re: [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx to json-schema

Lubomir Rintel
2020-05-17T19:30:49Z

On Fri, Mar 27, 2020 at 01:52:39PM -0600, Rob Herring wrote:
> On Tue, Mar 17, 2020 at 10:39:20AM +0100, Lubomir Rintel wrote:
> > A straightforward conversion of the the spi-pxa2xx binding to DT schema
> > format using json-schema.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> > .../bindings/spi/marvell,mmp2-ssp.yaml | 58 +++++++++++++++++++
> > .../devicetree/bindings/spi/spi-pxa2xx.txt | 27 ---------
> > 2 files changed, 58 insertions(+), 27 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
> > delete mode 100644 Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
> >
> > diff --git a/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml b/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
> > new file mode 100644
> > index 0000000000000..de6b6a53b70d8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
> > @@ -0,0 +1,58 @@
> > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
>
> Same issue on license...

I've written the original document and have chosen this license (for no
good reason, but I don't think that matters).

> > +# Copyright 2019,2020 Lubomir Rintel <lkundrak@v3.sk>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/spi/marvell,mmp2-ssp.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: PXA2xx SSP SPI Controller bindings
> > +
> > +maintainers:
> > + - Lubomir Rintel <lkundrak@v3.sk>
> > +
> > +allOf:
> > + - $ref: spi-controller.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: marvell,mmp2-ssp
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + ready-gpios:
> > + description: |
> > + GPIO used to signal a SPI master that the FIFO is filled and we're
> > + ready to service a transfer. Only useful in slave mode.
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
>
> > + - '#address-cells'
> > + - '#size-cells'
>
> spi-controller.yaml handles these being required and also that they
> aren't for slave mode.
>
> > +
> > +dependencies:
> > + ready-gpios: [ spi-slave ]
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/marvell,mmp2.h>
> > + spi@d4035000 {
> > + compatible = "marvell,mmp2-ssp";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0xd4035000 0x1000>;
> > + clocks = <&soc_clocks MMP2_CLK_SSP0>;
> > + interrupts = <0>;
> > + };
> > +
> > +...
> > diff --git a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt b/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
> > deleted file mode 100644
> > index e30e0c2a4bce1..0000000000000
> > --- a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
> > +++ /dev/null
> > @@ -1,27 +0,0 @@
> > -PXA2xx SSP SPI Controller
> > -
> > -Required properties:
> > -- compatible: Must be "marvell,mmp2-ssp".
> > -- reg: Offset and length of the device's register set.
> > -- interrupts: Should be the interrupt number.
> > -- clocks: Should contain a single entry describing the clock input.
> > -- #address-cells: Number of cells required to define a chip select address.
> > -- #size-cells: Should be zero.
> > -
> > -Optional properties:
> > -- cs-gpios: list of GPIO chip selects. See the SPI bus bindings,
> > - Documentation/devicetree/bindings/spi/spi-bus.txt
> > -- spi-slave: Empty property indicating the SPI controller is used in slave mode.
> > -- ready-gpios: GPIO used to signal a SPI master that the FIFO is filled
> > - and we're ready to service a transfer. Only useful in slave mode.
> > -
> > -Child nodes represent devices on the SPI bus
> > - See ../spi/spi-bus.txt
> > -
> > -Example:
> > - ssp1: spi@d4035000 {
> > - compatible = "marvell,mmp2-ssp";
> > - reg = <0xd4035000 0x1000>;
> > - clocks = <&soc_clocks MMP2_CLK_SSP0>;
> > - interrupts = <0>;
> > - };
> > --
> > 2.25.1
> >