From: Xia Jiang <xia.jiang@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rick Chang <rick.chang@mediatek.com>
Cc: <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tomasz Figa <tfiga@chromium.org>, <srv_heupstream@mediatek.com>,
<senozhatsky@chromium.org>, <mojahsu@chromium.org>,
<drinkcat@chromium.org>, <maoguang.meng@mediatek.com>,
<sj.huang@mediatek.com>, Xia Jiang <xia.jiang@mediatek.com>
Subject: [PATCH v9 06/18] media: platform: Delete the resetting hardware flow in the system PM ops
Date: Thu, 4 Jun 2020 15:26:56 +0800 [thread overview]
Message-ID: <20200604072708.9468-7-xia.jiang@mediatek.com> (raw)
In-Reply-To: <20200604072708.9468-1-xia.jiang@mediatek.com>
Delete the resetting hardware flow in suspend and resume function
because that resetting operation will be done in device_run().
Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
---
v9: new patch
---
check.txt | 13 +++++++++++++
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 --
2 files changed, 13 insertions(+), 2 deletions(-)
create mode 100644 check.txt
diff --git a/check.txt b/check.txt
new file mode 100644
index 000000000000..aed39e5f62f2
--- /dev/null
+++ b/check.txt
@@ -0,0 +1,13 @@
+WARNING:LONG_LINE: line over 80 characters
+#820: FILE: ./drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:820:
++ if (mtk_jpeg_set_dec_dst(ctx, &jpeg_src_buf->dec_param, &dst_buf->vb2_buf, &fb))
+
+total: 0 errors, 1 warnings, 1271 lines checked
+
+NOTE: For some of the reported defects, checkpatch may be able to
+ mechanically convert to the typical style using --fix or --fix-inplace.
+
+./drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c has style problems, please review.
+
+NOTE: If any of the errors are false positives, please report
+ them to the maintainer, see CHECKPATCH in MAINTAINERS.
diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index fb624385969e..7f74597262fc 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -1191,7 +1191,6 @@ static __maybe_unused int mtk_jpeg_pm_suspend(struct device *dev)
{
struct mtk_jpeg_dev *jpeg = dev_get_drvdata(dev);
- mtk_jpeg_dec_reset(jpeg->dec_reg_base);
mtk_jpeg_clk_off(jpeg);
return 0;
@@ -1202,7 +1201,6 @@ static __maybe_unused int mtk_jpeg_pm_resume(struct device *dev)
struct mtk_jpeg_dev *jpeg = dev_get_drvdata(dev);
mtk_jpeg_clk_on(jpeg);
- mtk_jpeg_dec_reset(jpeg->dec_reg_base);
return 0;
}
--
2.18.0
next prev parent reply other threads:[~2020-06-04 7:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 7:26 [PATCH v9 00/18] Add support for mt2701 JPEG ENC support Xia Jiang
2020-06-04 7:26 ` [PATCH v9 01/18] media: platform: Improve subscribe event flow for bug fixing Xia Jiang
2020-06-04 7:26 ` [PATCH v9 02/18] media: platform: Improve queue set up " Xia Jiang
2020-06-04 7:26 ` [PATCH v9 03/18] media: platform: Improve getting and requesting irq " Xia Jiang
2020-06-04 7:26 ` [PATCH v9 04/18] media: platform: Change the fixed device node number to unfixed value Xia Jiang
2020-06-04 7:26 ` [PATCH v9 05/18] media: platform: Improve power on and power off flow Xia Jiang
2020-06-04 7:26 ` Xia Jiang [this message]
2020-06-04 7:26 ` [PATCH v9 07/18] media: platform: Improve the implementation of the system PM ops Xia Jiang
2020-06-04 7:26 ` [PATCH v9 08/18] media: platform: Cancel the last frame handling flow Xia Jiang
2020-06-04 7:26 ` [PATCH v9 09/18] media: platform: Delete zeroing the reserved fields Xia Jiang
2020-06-04 7:27 ` [PATCH v9 10/18] media: platform: Stylistic changes for improving code quality Xia Jiang
2020-06-04 7:27 ` [PATCH v9 11/18] media: platform: Use generic rounding helpers Xia Jiang
2020-06-04 7:27 ` [PATCH v9 12/18] media: platform: Change MTK_JPEG_COMP_MAX macro definition location Xia Jiang
2020-06-04 7:27 ` [PATCH v9 13/18] media: platform: Delete redundant code and add annotation for an enum Xia Jiang
2020-06-04 7:27 ` [PATCH v9 14/18] media: dt-bindings: Add jpeg enc device tree node document Xia Jiang
2020-06-04 7:27 ` [PATCH v9 15/18] arm: dts: mt2701: Add jpeg enc device tree node Xia Jiang
2020-06-04 7:27 ` [PATCH v9 16/18] media: platform: Rename jpeg dec file name Xia Jiang
2020-06-04 7:27 ` [PATCH v9 17/18] media: platform: Rename existing functions/defines/variables Xia Jiang
2020-06-04 7:27 ` [PATCH v9 18/18] media: platform: Add jpeg enc feature Xia Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604072708.9468-7-xia.jiang@mediatek.com \
--to=xia.jiang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=maoguang.meng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=mojahsu@chromium.org \
--cc=rick.chang@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).